Documentation for DeliverySpec.Timeout#3793
Merged
knative-prow-robot merged 4 commits intoJun 24, 2021
Merged
Conversation
knative-prow-robot
added
the
size/M
Contributor
Author
|
/hold This is ready for review but the approval requires the approval of knative/eventing#5148 first |
knative-prow-robot
added
the
do-not-merge/hold
|
✔️ Deploy Preview for dev-knative ready! 🔨 Explore the source changes: 8b02200 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60d03543f84f1d0007fa8583 😎 Browse the preview: https://deploy-preview-3793--dev-knative.netlify.app/development/eventing/experimental-features |
knative-prow-robot
added
the
needs-rebase
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper
force-pushed
the
delivery-timeout
branch
from
ac9adec to
cd01d9b
Compare
knative-prow-robot
removed
the
needs-rebase
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
8 tasks
Contributor
Author
|
/unhold |
knative-prow-robot
removed
the
do-not-merge/hold
Contributor
Author
|
@abrennan89 can you check this out? |
abrennan89
reviewed
Jun 22, 2021
abrennan89
reviewed
Jun 22, 2021
abrennan89
reviewed
Jun 22, 2021
abrennan89
reviewed
Jun 22, 2021
Contributor
Author
|
/hold Let's wait for knative/eventing#5507 to be merged first |
knative-prow-robot
added
the
do-not-merge/hold
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Contributor
|
/retest |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrennan89, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Contributor
Author
|
/unhold |
knative-prow-robot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Francesco Guardiani francescoguard@gmail.com
Proposed Changes