Skip to content

Relocating ContainerSource docs to dev guide#3807

Merged
knative-prow-robot merged 2 commits into
knative:mkdocsfrom
snneji:relocate-containersource-docs
Jun 28, 2021
Merged

Relocating ContainerSource docs to dev guide#3807
knative-prow-robot merged 2 commits into
knative:mkdocsfrom
snneji:relocate-containersource-docs

Conversation

@snneji
Copy link
Copy Markdown
Contributor

@snneji snneji commented Jun 15, 2021

In PR #3774 I moved the ContainerSource docs to the developer guide in the navigation, but forgot to relocate the files in the directory structure. This PR fixes that.

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 15, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 15, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 15, 2021

✔️ Deploy Preview for dev-knative ready!

🔨 Explore the source changes: afefd1b

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60d9be365c4d1900071decbb

😎 Browse the preview: https://deploy-preview-3807--dev-knative.netlify.app

@snneji
Copy link
Copy Markdown
Contributor Author

snneji commented Jun 16, 2021

@abrennan89 as you suggested I moved the ContainerSource docs to the developer section of the directory.

@abrennan89
Copy link
Copy Markdown
Contributor

Thanks @snneji !

I just wanted to double check, is there any further update needed to mkdocs.yaml for this PR?

The links seem to work fine, e.g. https://deploy-preview-3807--dev-knative.netlify.app/development/eventing/sources/containersource/ but I think it should be (development)/developer/eventing/sources/containersource, so it seems like the links are still pointing to just eventing/sources if that makes sense, rather than developer/eventing/sources?

@snneji
Copy link
Copy Markdown
Contributor Author

snneji commented Jun 28, 2021

@abrennan89 thanks for spotting that issue with the URL. I believe I've fixed it.

Copy link
Copy Markdown
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, snneji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants