Skip to content

#3349: Updated traffic management docs, blue/green deployment#3825

Merged
knative-prow-robot merged 5 commits into
knative:mkdocsfrom
abrennan89:3349
Jul 7, 2021
Merged

#3349: Updated traffic management docs, blue/green deployment#3825
knative-prow-robot merged 5 commits into
knative:mkdocsfrom
abrennan89:3349

Conversation

@abrennan89
Copy link
Copy Markdown
Contributor

@abrennan89 abrennan89 commented Jun 18, 2021

Fixes #3349

Proposed Changes

  • Moved docs from samples to developer guide
  • Clean up / editing content
  • Removed superfluous sample files, included examples directly in docs instead to reduce confusion

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2021
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 18, 2021
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 18, 2021
@abrennan89 abrennan89 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 18, 2021

✔️ Deploy Preview for dev-knative ready!

🔨 Explore the source changes: 39f9174

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60ccf22a48e6f400087c10f4

😎 Browse the preview: https://deploy-preview-3825--dev-knative.netlify.app

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 18, 2021 •
edited
Loading

✔️ Deploy Preview for dev-knative ready!

🔨 Explore the source changes: 0edd850

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60e5b24be2e0df0007a47589

😎 Browse the preview: https://deploy-preview-3825--dev-knative.netlify.app

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2021
@abrennan89 abrennan89 marked this pull request as draft July 1, 2021 14:17
abrennan89
abrennan89 commented Jul 6, 2021
View reviewed changes
Comment thread docs/developer/serving/traffic-management.md
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2021
@abrennan89 abrennan89 marked this pull request as ready for review July 6, 2021 21:28
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2021
rhuss
rhuss reviewed Jul 7, 2021
View reviewed changes
Comment thread docs/developer/serving/traffic-management.md
rhuss
rhuss reviewed Jul 7, 2021
View reviewed changes
Comment thread docs/developer/serving/traffic-management.md
rhuss
rhuss reviewed Jul 7, 2021
View reviewed changes
Comment thread docs/developer/serving/traffic-management.md
@rhuss rhuss mentioned this pull request Jul 7, 2021
Closed
rhuss
rhuss reviewed Jul 7, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me ! I would add two additional kn samples for how to set a tag and how to use @latest. But please note, that we are currently still rethinking the UI surface of the command (like adding additional @previous or @current to specify the latestCreatedRevision that is often needed to cover various use cases), so maybe we should rework the kn section when we have nailed down the new options, to avoid extra work ?

@omerbensaadon
Copy link
Copy Markdown

omerbensaadon commented Jul 7, 2021

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021
@abrennan89 abrennan89 requested a review from rhuss July 7, 2021 13:57
@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Jul 7, 2021

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021
@knative-prow-robot knative-prow-robot merged commit 54290e2 into knative:mkdocs Jul 7, 2021
This was referenced Sep 5, 2021
Open
Open
Open
Open
@abrennan89 abrennan89 deleted the 3349 branch August 26, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

@dsimansk dsimansk Awaiting requested review from dsimansk

@rhuss rhuss Awaiting requested review from rhuss

Assignees

@rhuss rhuss

@omerbensaadon omerbensaadon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update blue/green deployment docs

4 participants

@abrennan89 @knative-prow-robot @omerbensaadon @rhuss