Tame the footer and make the prev/next stand out#3918
Merged
Conversation
Originally the prev/next links looked like they were part of the header and were easy to miss. This makes it more obvious while at the same time making the header look more sleek.
knative-prow-robot
added
the
size/S
|
✔️ Deploy Preview for dev-knative ready! 🔨 Explore the source changes: fed4c9c 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60df45924fcd840007ad2ed3 😎 Browse the preview: https://deploy-preview-3918--dev-knative.netlify.app |
|
|
Contributor
Author
|
@omerbensaadon the issues you seeing in that screenshot should be addressed. |
|
This looks so slick, thanks Krsa! /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kvmware, omerbensaadon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally the prev/next links looked like they were part of the header and were easy to miss. This makes it more obvious while at the same time making the header look more sleek.
"Fixes #issue-number" or "Add description of the problem this PR solves"
Proposed Changes