Skip to content

Refactor DNS snippets#3967

Merged
knative-prow-robot merged 2 commits into
knative:mkdocsfrom
julz:itsalwaysdns
Jul 7, 2021
Merged

Refactor DNS snippets#3967
knative-prow-robot merged 2 commits into
knative:mkdocsfrom
julz:itsalwaysdns

Conversation

@julz
Copy link
Copy Markdown
Contributor

@julz julz commented Jul 7, 2021

Splits in to multiple files so that Operator can have a different version for the Real DNS section.

/assign @cardil - please could you check I got this right this time 😅

@julz
Refactor DNS snippets
c971c5b 
Splits in to multiple files so that Operator can have a different version for the Real DNS section.
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 7, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 7, 2021 •
edited
Loading

✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: 1d76e4a

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/60e5f3e2d8c14c00087e56bf

😎 Browse the preview: https://deploy-preview-3967--knative.netlify.app

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 7, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 7, 2021 •
edited
Loading

✔️ Deploy Preview for dev-knative ready!

🔨 Explore the source changes: 1d76e4a

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60e5f3e202a0ae0007165ca2

😎 Browse the preview: https://deploy-preview-3967--dev-knative.netlify.app

@julz
Copy link
Copy Markdown
Contributor Author

julz commented Jul 7, 2021

/assign @cardil

@julz
Copy link
Copy Markdown
Contributor Author

julz commented Jul 7, 2021

/cherry-pick release-0.24

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 7, 2021

@julz: once the present PR merges, I will cherry-pick it on top of release-0.24 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-0.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cardil
cardil approved these changes Jul 7, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks well. Thanks a lot!

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, julz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit ea0a6fd into knative:mkdocs Jul 7, 2021
@knative-prow-robot knative-prow-robot mentioned this pull request Jul 7, 2021
Merged
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 7, 2021

@julz: new pull request created: #3968

Details

In response to this:

/cherry-pick release-0.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

snneji pushed a commit to snneji/docs that referenced this pull request Jul 8, 2021
@julz @snneji
Refactor DNS snippets (knative#3967)
735526f 
* Refactor DNS snippets

Splits in to multiple files so that Operator can have a different version for the Real DNS section.

* fix formatting
@snyk-bot snyk-bot mentioned this pull request Feb 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cardil cardil cardil approved these changes

Assignees

@cardil cardil

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@julz @knative-prow-robot @cardil