Skip to content

Remove reference to domainmapping yaml#3980

Merged
knative-prow-robot merged 1 commit into
knative:mkdocsfrom
julz:unmapdomainmapping
Jul 8, 2021
Merged

Remove reference to domainmapping yaml#3980
knative-prow-robot merged 1 commit into
knative:mkdocsfrom
julz:unmapdomainmapping

Conversation

@julz
Copy link
Copy Markdown
Contributor

@julz julz commented Jul 8, 2021

The DomainMapping feature is now beta, and therefore built in to the
main yaml files. These links are therefore now 404s.

/assign @dprotaso @omerbensaadon

The DomainMapping feature is now beta, and therefore built in to the
main yaml files. These links are therefore now 404s.
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 8, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 8, 2021

✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: d9ce00b

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/60e718929c5d3a00078a281d

😎 Browse the preview: https://deploy-preview-3980--knative.netlify.app

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 8, 2021
@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Jul 8, 2021

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, julz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Jul 8, 2021

@julz do we want to cherry pick this?

@julz
Copy link
Copy Markdown
Contributor Author

julz commented Jul 8, 2021

Oh good catch @dprotaso, yes

/cherry-pick release-0.24

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@julz: once the present PR merges, I will cherry-pick it on top of release-0.24 in a new PR and assign it to you.

Details

In response to this:

Oh good catch @dprotaso, yes

/cherry-pick release-0.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@julz: new pull request created: #3983

Details

In response to this:

Oh good catch @dprotaso, yes

/cherry-pick release-0.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants