Remove reference to domainmapping yaml#3980
Conversation
The DomainMapping feature is now beta, and therefore built in to the main yaml files. These links are therefore now 404s.
|
✔️ Deploy Preview for knative ready! 🔨 Explore the source changes: d9ce00b 🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/60e718929c5d3a00078a281d 😎 Browse the preview: https://deploy-preview-3980--knative.netlify.app |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, julz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@julz do we want to cherry pick this? |
|
Oh good catch @dprotaso, yes /cherry-pick release-0.24 |
|
@julz: once the present PR merges, I will cherry-pick it on top of release-0.24 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@julz: new pull request created: #3983 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The DomainMapping feature is now beta, and therefore built in to the main yaml files. These links are therefore now 404s.
The DomainMapping feature is now beta, and therefore built in to the
main yaml files. These links are therefore now 404s.
/assign @dprotaso @omerbensaadon