Skip to content

document serving's revision garbage collection#4266

Merged
knative-prow-robot merged 8 commits into
knative:mainfrom
dprotaso:document-gc
Sep 21, 2021
Merged

document serving's revision garbage collection#4266
knative-prow-robot merged 8 commits into
knative:mainfrom
dprotaso:document-gc

Conversation

@dprotaso
Copy link
Copy Markdown
Member

@dprotaso dprotaso commented Sep 20, 2021 •
edited
Loading

No description provided.

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 20, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 20, 2021 •
edited
Loading

✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: 186fcde

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/6149fb653a961a0007e018de

😎 Browse the preview: https://deploy-preview-4266--knative.netlify.app/development/admin/serving/revision-gc

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 20, 2021
This was referenced Sep 20, 2021
Closed
Closed
@dprotaso dprotaso changed the title document serving's garbage collector document serving's revision garbage collection Sep 20, 2021
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 20, 2021
abrennan89
abrennan89 reviewed Sep 20, 2021
View reviewed changes
Comment thread config/nav.yml Outdated
abrennan89
abrennan89 reviewed Sep 20, 2021
View reviewed changes
Comment thread config/nav.yml Outdated
abrennan89
abrennan89 reviewed Sep 20, 2021
View reviewed changes
Comment thread docs/admin/serving/revision-gc.md Outdated
abrennan89
abrennan89 reviewed Sep 20, 2021
View reviewed changes
Comment thread docs/admin/serving/revision-gc.md Outdated
abrennan89
abrennan89 reviewed Sep 20, 2021
View reviewed changes
Comment thread docs/admin/serving/revision-gc.md Outdated
abrennan89
abrennan89 reviewed Sep 20, 2021
View reviewed changes
Comment thread docs/admin/serving/revision-gc.md
abrennan89
abrennan89 reviewed Sep 20, 2021
View reviewed changes
Comment thread docs/admin/serving/revision-gc.md Outdated
abrennan89
abrennan89 reviewed Sep 20, 2021
View reviewed changes
Comment thread docs/admin/serving/revision-gc.md Outdated
abrennan89
abrennan89 reviewed Sep 20, 2021
View reviewed changes
Comment thread docs/admin/serving/revision-gc.md Outdated
abrennan89
abrennan89 reviewed Sep 20, 2021
View reviewed changes
Comment thread docs/admin/serving/revision-gc.md Outdated
abrennan89
abrennan89 reviewed Sep 20, 2021
View reviewed changes
Comment thread docs/admin/serving/revision-gc.md Outdated
abrennan89
abrennan89 reviewed Sep 20, 2021
View reviewed changes
Comment thread docs/serving/revision-gc.md Outdated
abrennan89
abrennan89 reviewed Sep 20, 2021
View reviewed changes
Comment thread docs/serving/revision-gc.md Outdated
abrennan89
abrennan89 reviewed Sep 20, 2021
View reviewed changes
Comment thread docs/serving/revision-gc.md Outdated
abrennan89
abrennan89 reviewed Sep 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@abrennan89 abrennan89 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to bring this in line with the doc guidelines and fix some typos etc.

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2021
@julz
Copy link
Copy Markdown
Contributor

julz commented Sep 20, 2021

Think this “Fixes #3461“, thanks @dprotaso!

abrennan89
abrennan89 reviewed Sep 21, 2021
View reviewed changes
Comment thread docs/admin/serving/revision-gc.md
abrennan89
abrennan89 reviewed Sep 21, 2021
View reviewed changes
Comment thread docs/admin/serving/revision-gc.md Outdated
abrennan89
abrennan89 reviewed Sep 21, 2021
View reviewed changes
Comment thread docs/admin/serving/revision-gc.md Outdated
abrennan89
abrennan89 reviewed Sep 21, 2021
View reviewed changes
Comment thread docs/admin/serving/revision-gc.md Outdated
abrennan89
abrennan89 reviewed Sep 21, 2021
View reviewed changes
Comment thread docs/admin/serving/revision-gc.md Outdated
abrennan89
abrennan89 reviewed Sep 21, 2021
View reviewed changes
Comment thread docs/serving/revision-gc.md Outdated
abrennan89
abrennan89 reviewed Sep 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final comments, mostly fixing formatting that's broken in the preview

abrennan89
abrennan89 reviewed Sep 21, 2021
View reviewed changes
Comment thread docs/admin/serving/revision-gc.md Outdated
abrennan89
abrennan89 reviewed Sep 21, 2021
View reviewed changes
Comment thread docs/admin/serving/revision-gc.md Outdated
abrennan89
abrennan89 approved these changes Sep 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @dprotaso !

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Sep 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abrennan89,dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abrennan89 abrennan89 linked an issue Sep 21, 2021 that may be closed by this pull request
Add documentation for the revision garbage collector #3461
Closed
@knative-prow-robot knative-prow-robot merged commit fbe03bb into knative:main Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@abrennan89 abrennan89 abrennan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abrennan89 abrennan89

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add documentation for the revision garbage collector

4 participants

@dprotaso @julz @knative-prow-robot @abrennan89