Skip to content

DeliverySpec.RetryAfter Experimental-Feature#4361

Merged
knative-prow-robot merged 11 commits into
knative:mainfrom
travis-minke-sap:retry-after-experimental-feature
Dec 1, 2021
Merged

DeliverySpec.RetryAfter Experimental-Feature#4361
knative-prow-robot merged 11 commits into
knative:mainfrom
travis-minke-sap:retry-after-experimental-feature

Conversation

@travis-minke-sap
Copy link
Copy Markdown
Contributor

@travis-minke-sap travis-minke-sap commented Oct 13, 2021 •
edited
Loading

This change id based on eventing Issue #5811 for which the initial implementation has been merged.

Proposed Changes

  • Document proposed experimental-feature for supporting Retry-After headers.

Ready for review now that the initial Retry-After implementation has been merged!

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2021
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 13, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 13, 2021 •
edited
Loading

✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: a974489

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/61a675ee0f1fda0007c572ce

😎 Browse the preview: https://deploy-preview-4361--knative.netlify.app/development/eventing/experimental-features

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 13, 2021
This was referenced Oct 13, 2021
Open
Merged
@csantanapr csantanapr requested a review from snneji November 29, 2021 20:30
@csantanapr
Copy link
Copy Markdown
Member

csantanapr commented Nov 29, 2021

This is ready for review @snneji if you want to take a look

@csantanapr
Copy link
Copy Markdown
Member

csantanapr commented Nov 29, 2021

@travis-minke-sap you don't need to put a hold for review, when something is in hold means we are going to ignore it and assume the PR submitter is still working on changes to be submitted and not ready yet

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2021
csantanapr
csantanapr reviewed Nov 29, 2021
View reviewed changes
Comment thread docs/eventing/experimental-features.md Outdated
snneji
snneji suggested changes Nov 30, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@snneji snneji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few style tweaks.

Comment thread docs/eventing/experimental-features.md Outdated
Comment thread docs/eventing/experimental-features.md Outdated
Comment thread docs/eventing/experimental-features.md Outdated
Comment thread docs/eventing/experimental-features.md Outdated
Comment thread docs/eventing/experimental-features.md Outdated
Comment thread docs/eventing/experimental-features.md Outdated
Comment thread docs/eventing/experimental-features.md Outdated
Comment thread docs/eventing/experimental-features.md Outdated
Comment thread docs/eventing/experimental-features.md Outdated
@travis-minke-sap
Copy link
Copy Markdown
Contributor Author

travis-minke-sap commented Nov 30, 2021

A few style tweaks.

Thanks for the great review @snneji - much appreciated - I've made the suggested changes.

@snneji
Copy link
Copy Markdown
Contributor

snneji commented Dec 1, 2021

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2021
@snneji
Copy link
Copy Markdown
Contributor

snneji commented Dec 1, 2021

I added the hold label back as I see the issue knative/eventing#5811 hasn't closed yet, although it seems that PR knative/eventing#5813 related to that issue has been merged. You can unhold again if it's ready.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Dec 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: snneji, travis-minke-sap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travis-minke-sap
Copy link
Copy Markdown
Contributor Author

travis-minke-sap commented Dec 1, 2021

I added the hold label back as I see the issue knative/eventing#5811 hasn't closed yet, although it seems that PR knative/eventing#5813 related to that issue has been merged. You can unhold again if it's ready.

Yeah, the intent is for the Issue to remain open during the lifecycle of the "experimental-feature" and the important thing is that the initial development work is in place. Thanks again!

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2021
@knative-prow-robot knative-prow-robot merged commit deb4acb into knative:main Dec 1, 2021
@travis-minke-sap travis-minke-sap deleted the retry-after-experimental-feature branch December 1, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@csantanapr csantanapr csantanapr left review comments

@snneji snneji snneji approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@snneji snneji

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@travis-minke-sap @csantanapr @snneji @knative-prow-robot