Skip to content

Fixes kafkasource bugs#5006

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
abrennan89:kafkasource-bugs
Jun 6, 2022
Merged

Fixes kafkasource bugs#5006
knative-prow[bot] merged 1 commit into
knative:mainfrom
abrennan89:kafkasource-bugs

Conversation

@abrennan89
Copy link
Copy Markdown
Contributor

Fixes #3081

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 6, 2022

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 68c27fd
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/629e1a2d06e7850008d0d598
😎 Deploy Preview https://deploy-preview-5006--knative.netlify.app/docs/eventing/sources/kafka-source
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow knative-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 6, 2022
Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2022
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Jun 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot merged commit 7df2547 into knative:main Jun 6, 2022
@abrennan89 abrennan89 deleted the kafkasource-bugs branch August 26, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apache Kafka Source Example(docs/eventing/samples/kafka/source/index.md) Discrepancies

2 participants