Skip to content

Conversation

@psschwei
Copy link
Member

Signed-off-by: Paul S. Schweigert paul@paulschweigert.com

xref: knative/pkg#2595

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2022
@netlify
Copy link

netlify bot commented Sep 16, 2022

Deploy Preview for knative ready!

Name Link
🔨 Latest commit 936cb4a
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/632493513d513e0009cc1aa2
😎 Deploy Preview https://deploy-preview-5221--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 16, 2022
@abrennan89
Copy link
Contributor

/lgtm
/approve

@psschwei is this only for the upcoming latest version or does it need to be cherrypicked to any others?

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2022
@knative-prow
Copy link

knative-prow bot commented Sep 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abrennan89,psschwei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit ea10e69 into knative:main Sep 22, 2022
@psschwei
Copy link
Member Author

@psschwei is this only for the upcoming latest version or does it need to be cherrypicked to any others?

just the upcoming release, no need to cherrypick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants