Skip to content

Remove information about strict-subscriber flag again#5332

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
creydr:remove-docs-about-strict-subscriber-flag
Nov 18, 2022
Merged

Remove information about strict-subscriber flag again#5332
knative-prow[bot] merged 1 commit into
knative:mainfrom
creydr:remove-docs-about-strict-subscriber-flag

Conversation

@creydr
Copy link
Copy Markdown
Member

@creydr creydr commented Nov 18, 2022

The strict-subscriber feature flag was removed in knative/eventing#6608 so the validation cannot be disabled anymore. This commit adjusts the docs too.

Proposed Changes

  • remove information about the strict-subscriber flag from the docs again

The strict-subscriber feature flag was removed in
knative/eventing#6608 so the validation cannot
be disabled anymore. This commit adjusts the docs too.

Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
@knative-prow knative-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 18, 2022

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 074c155
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/637742f7d8441b00082f8aca
😎 Deploy Preview https://deploy-preview-5332--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@creydr creydr marked this pull request as ready for review November 18, 2022 08:44
@knative-prow knative-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2022
Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2022
Copy link
Copy Markdown
Member

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Nov 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2022
@knative-prow knative-prow Bot merged commit 40e9677 into knative:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants