This repository was archived by the owner on Jun 4, 2021. It is now read-only.
Soft-revert #137 "Use CR unstructured client for dynamic objects"#179
Closed
grantr wants to merge 2 commits into
Closed
Soft-revert #137 "Use CR unstructured client for dynamic objects"#179grantr wants to merge 2 commits into
grantr wants to merge 2 commits into
Conversation
The previous version that used the dynamic client is now called GetSinkURI_DC. The new version that uses the controller-runtime client is now called GetSinkURI_CR. GetSinkURI is now a reference to GetSinkURI_DC because it's the only one known to work.
The controllers written before knative#137 are reverted to use the dynamic client. More recent controllers cronjobsource and awssqssource use the controller-runtime client still, since there was never a version of them that used the dynamic client.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
knative-prow-robot
added
the
size/XXL
|
The following is the coverage report on pkg/.
|
This was referenced Jan 11, 2019
Member
|
Looks like this is not needed. |
lionelvillard
added a commit
to lionelvillard/eventing-contrib
that referenced
this pull request
Nov 10, 2020
knative-prow-robot
pushed a commit
that referenced
this pull request
Nov 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to track down the issues caused by knative/eventing#718.
It creates two versions of GetSinkURI, pre-#137 (dynamic clients) and post-#137 (controller-runtime unstructured client). The older sources have been reverted to use the dynamic clients version. The cronjobsource and awssqssource never had dynamic client versions, so they still use the controller-runtime unstructured client version.
If the eventing e2e tests pass with this change, then it seems clear that #137 caused them.