Skip to content
This repository was archived by the owner on Jun 4, 2021. It is now read-only.

Delete KubernetesEventSource, replaced by ApiServerSource#404

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
n3wscott:delete_k8s_source
May 10, 2019
Merged

Delete KubernetesEventSource, replaced by ApiServerSource#404
knative-prow-robot merged 2 commits into
knative:masterfrom
n3wscott:delete_k8s_source

Conversation

@n3wscott
Copy link
Copy Markdown
Contributor

@n3wscott n3wscott commented May 8, 2019

Proposed Changes

  • Remove KubernetesEventSource, replaced by ApiServerSource

Release Note

KubernetesEventSource will no longer ship with eventing-sources. Migrate to ApiServerSource found in knative/eventing.

follow-up to knative/eventing#1175

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 8, 2019
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 8, 2019
@n3wscott
Copy link
Copy Markdown
Contributor Author

n3wscott commented May 8, 2019

/hold
until knative/eventing#1175 lands

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2019
@n3wscott n3wscott mentioned this pull request May 8, 2019
Merged
@n3wscott
Copy link
Copy Markdown
Contributor Author

n3wscott commented May 8, 2019

Istio still having a bad day over here.

/retest

@n3wscott
Copy link
Copy Markdown
Contributor Author

n3wscott commented May 10, 2019

/hold cancel

This is now ready.

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2019
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented May 10, 2019

Can you also link a corresponding issue / PR for the documentations website?

@n3wscott n3wscott mentioned this pull request May 10, 2019
Closed
@n3wscott
Copy link
Copy Markdown
Contributor Author

n3wscott commented May 10, 2019

This one: knative/docs#1301

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented May 10, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented May 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [n3wscott,vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 5466aed into knative:master May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Harwayne Harwayne Awaiting requested review from Harwayne

@matzew matzew Awaiting requested review from matzew

Assignees

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@n3wscott @vaikas @knative-prow-robot @googlebot