This repository was archived by the owner on Jun 4, 2021. It is now read-only.
Updating dependencies - Fixing Channels #635
Merged
Merged
Conversation
GitHub webhooks cannot be created otherwise.
Contributor
Author
|
/hold cancel |
Contributor
Author
|
/hold dumping logs |
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
Contributor
Author
|
/hold |
Contributor
Author
|
The following is the coverage report on the affected files.
|
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
knative.dev/pkg,knative.dev/eventing,knative.dev/servingk8s.io/client-go, which we were overriding to 1.12. I ended up increasing allk8s.iodeps tokubernetes-1.15.3, to match eventing, serving, and pkg.k8s.io, also needed to update controller-runtime (to 0.2.2). I had to do a changes in testing code, and some other client calls, due to this change.NOTE for the Reviewer(s):
Release Note