Skip to content
This repository was archived by the owner on Jun 4, 2021. It is now read-only.

Updating dependencies - Fixing Channels #635

Merged
knative-prow-robot merged 85 commits into
knative:masterfrom
nachocano:master
Oct 1, 2019
Merged

Updating dependencies - Fixing Channels #635
knative-prow-robot merged 85 commits into
knative:masterfrom
nachocano:master

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

@nachocano nachocano commented Sep 27, 2019

Proposed Changes

  • Updated knative.dev/pkg, knative.dev/eventing, knative.dev/serving
  • pkg needed some newer k8s.io/client-go, which we were overriding to 1.12. I ended up increasing all k8s.io deps to kubernetes-1.15.3, to match eventing, serving, and pkg.
  • With the newer k8s.io, also needed to update controller-runtime (to 0.2.2). I had to do a changes in testing code, and some other client calls, due to this change.
  • Moving message_dispatcher and message_receiver to eventing-contrib in order not to break the NATSS nor the Kafka channels whenever we updated the dep to eventing. There are TODOs in the code with links to issues of what should be removed once we start using event_receiver and event_dispatcher from eventing.
  • Few nits (couchdb controller needed configmaps permissions, added URL to printed columns, code-gen for channels, etc, etc.)

NOTE for the Reviewer(s):

  • Don't be scared about the amount of files changed. They are mostly vendored :)
  • Applied everything (githubsource, awssqssource, camel, couchdbsource, kafkasource, kafkachannel, and natsschannel), and all controllers started.
  • Tested the kafka and natss channels data planes and I was able to see events flowing.
  • This will have to be done for the 0.10 cut, so let's do it soon in case there are any issues...

Release Note

NONE

GitHub webhooks cannot be created otherwise.
@nachocano
Copy link
Copy Markdown
Contributor Author

/hold cancel
doing the patching that eventing does for now

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

/hold dumping logs

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
camel/source/pkg/reconciler/camelsource.go 61.4% 61.1% -0.3
github/pkg/reconciler/githubsource.go 85.6% 85.7% 0.1
kafka/source/pkg/reconciler/kafkasource.go 84.0% 84.1% 0.2
pkg/channel/message.go Do not exist 50.0%
pkg/channel/message_dispatcher.go Do not exist 86.6%
pkg/channel/message_receiver.go Do not exist 74.3%

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
camel/source/pkg/reconciler/camelsource.go 61.4% 61.1% -0.3
github/pkg/reconciler/githubsource.go 85.6% 85.7% 0.1
kafka/source/pkg/reconciler/kafkasource.go 84.0% 84.1% 0.2
pkg/channel/message.go Do not exist 50.0%
pkg/channel/message_dispatcher.go Do not exist 86.6%
pkg/channel/message_receiver.go Do not exist 74.3%

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
camel/source/pkg/reconciler/camelsource.go 61.4% 61.1% -0.3
github/pkg/reconciler/githubsource.go 85.6% 85.7% 0.1
kafka/source/pkg/reconciler/kafkasource.go 84.0% 84.1% 0.2
pkg/channel/message.go Do not exist 50.0%
pkg/channel/message_dispatcher.go Do not exist 86.6%
pkg/channel/message_receiver.go Do not exist 74.3%

@nachocano
Copy link
Copy Markdown
Contributor Author

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2019
Comment thread pkg/channel/message_dispatcher_test.go
Comment thread pkg/channel/message_receiver_test.go
Comment thread hack/set-span-id.patch
@nachocano
Copy link
Copy Markdown
Contributor Author

/hold cancel

we are skipping the two e2e tests failing for now. Created an issue #639 to unblock us.... We narrowed it down to a particular PR in eventing, which we will continue to investigate...

fyi @chizhg @Harwayne

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2019
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
camel/source/pkg/reconciler/camelsource.go 61.4% 61.1% -0.3
github/pkg/reconciler/githubsource.go 85.6% 85.7% 0.1
kafka/source/pkg/reconciler/kafkasource.go 84.0% 84.1% 0.2
pkg/channel/message.go Do not exist 50.0%
pkg/channel/message_dispatcher.go Do not exist 86.6%
pkg/channel/message_receiver.go Do not exist 74.3%

@chizhg
Copy link
Copy Markdown
Contributor

chizhg commented Oct 1, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2019
@knative-prow-robot knative-prow-robot merged commit 4f4d1cf into knative:master Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants