Build config consistently as per in serving#105
Conversation
|
Hi @aliok. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Build config consistently as per in serving (#105) * Add upgrade tests into the e2e-tests-latest-eventing (#93) * Add upgrade tests into the e2e-tests-latest-eventing This PR adds the tests to verify the correct number and names of knative eventing deployments. The test tag postupgrade is added, marking the tests to run after upgrade to the latest HEAD of operator, with the latest generated manifest of knative eventing. * Add the installation of the previous release and upgrade to the latest * Fixes this PR based on the latest comments * Add additionalPrinterColumns (#98) * Update the library from jcrossley3/manifestival to manifestival Co-authored-by: Ali Ok <aliok@redhat.com>
4 participants
Config building in main and in controller is now done using the same method. This was done in serving PR knative/serving-operator#293
cc @markusthoemmes