[BUG]E2E test for default Broker is flaky

[chizhg]

Describe the bug
The E2E test case for testing the default broker, which uses in-memory ClusterChannelProvisioner, is flaky. Please refer the detailed log here.

Expected behavior
The test case can pass consistently for a fixed version of project.

To Reproduce
There is no fixed steps to reproduce.

[vaikas]

Looks like the type2-source1 is not being found, the other 3 event-types are there.

e2e.go:405: Could not find content "Body-type2-source1" for dumper-testany-testany/logevents. Found "2019/04/22 03:47:02 will listen on :8080\n2019/04/22 03:47:45 Validation: valid\nContext Attributes,\n specversion: 0.2\n type: type1\n source: source1\n id: 5a5062aa-772f-474c-8886-7c0805df8a2f\n time: 2019-04-22T03:47:45.362746268Z\n contenttype: application/json\nExtensions,\n knativehistory: default-broker-g2sn7-channel-dd2bf.test-default-broker-with-many-triggers-in-memory.svc.cluster.local\nData,\n {\n "msg": "Body-type1-source1",\n "sequence": "1"\n }\n2019/04/22 03:47:45 Validation: valid\nContext Attributes,\n specversion: 0.2\n type: type1\n source: source2\n id: 8f1e88b9-7c36-4be8-9ba6-4c37b854e228\n time: 2019-04-22T03:47:45.327749132Z\n contenttype: application/json\nExtensions,\n knativehistory: default-broker-g2sn7-channel-dd2bf.test-default-broker-with-many-triggers-in-memory.svc.cluster.local\nData,\n {\n "msg": "Body-type1-source2",\n "sequence": "1"\n }\n2019/04/22 03:47:45 Validation: valid\nContext Attributes,\n specversion: 0.2\n type: type2\n source: source2\n id: 6316ae10-2f4b-4c79-982b-3be4a04eac88\n time: 2019-04-22T03:47:45.48177412Z\n contenttype: application/json\nExtensions,\n knativehistory: default-broker-g2sn7-channel-dd2bf.test-default-broker-with-many-triggers-in-memory.svc.cluster.local\nData,\n {\n "msg": "Body-type2-source2",\n "sequence": "1"\n }\n" instead

formatter bit nicer:
e2e.go:499: Logs for the container "logevents" of the pod %!i(string=dumper-testany-testany)n namespace "test-default-broker-with-many-triggers-in-memory":
2019/04/22 03:47:02 will listen on :8080
2019/04/22 03:47:45 Validation: valid
Context Attributes,
specversion: 0.2
type: type1
source: source1
id: 5a5062aa-772f-474c-8886-7c0805df8a2f
time: 2019-04-22T03:47:45.362746268Z
contenttype: application/json
Extensions,
knativehistory: default-broker-g2sn7-channel-dd2bf.test-default-broker-with-many-triggers-in-memory.svc.cluster.local
Data,
{
"msg": "Body-type1-source1",
"sequence": "1"
}
2019/04/22 03:47:45 Validation: valid
Context Attributes,
specversion: 0.2
type: type1
source: source2
id: 8f1e88b9-7c36-4be8-9ba6-4c37b854e228
time: 2019-04-22T03:47:45.327749132Z
contenttype: application/json
Extensions,
knativehistory: default-broker-g2sn7-channel-dd2bf.test-default-broker-with-many-triggers-in-memory.svc.cluster.local
Data,
{
"msg": "Body-type1-source2",
"sequence": "1"
}
2019/04/22 03:47:45 Validation: valid
Context Attributes,
specversion: 0.2
type: type2
source: source2
id: 6316ae10-2f4b-4c79-982b-3be4a04eac88
time: 2019-04-22T03:47:45.48177412Z
contenttype: application/json
Extensions,
knativehistory: default-broker-g2sn7-channel-dd2bf.test-default-broker-with-many-triggers-in-memory.svc.cluster.local
Data,
{
"msg": "Body-type2-source2",
"sequence": "1"
}
broker_trigger_test.go:222: Event(s) not found in logs of subscriber pod "dumper-testany-testany": timed out waiting for the condition

[chizhg]

This test case isn't flaky anymore, close it.