Should sources have a spec.eventType always, start support for upstream filtering?

[n3wscott]

Expand on the source registry with #1856 (comment)

While working on the Kn Eventing proposal, I remarked that this proposal supports a field .spec.eventTypes for all sources, which might be worth to consider to be included into this spec. This should be an array of event types for which an instance of this source CRD is configured to emit.

Does this make sense to add it as an (optional ?) field into this source specification ?

// @Harwayne @sixolet

Originally posted by @rhuss in #1856 (comment)

[nachocano]

fyi @aaron-lerner

[loonybear]

Hi, any progress on this?

Right now the only way to associate eventType with a source+trigger model is via trigger.spec.filter.attributes['type'], but I think we are hoping to decouple event type with trigger?

[loonybear]

I don't think it is safe to assume a trigger is always created with a filter attribute on type.

I don't know how broker works so my question might not be valid:
Say I have a Source of kind SourceA, SourceA has 4 registered event types
Say I have a Trigger, with an dependency annotation on the Source, without any filter on event type.

Then does this mean all 4 event types are now going to trigger the subscriber of my Trigger?

[loonybear]

So if we specify eventType in SourceSpec, then we know exactly which event type will invoke my Trigger subscriber.

And we can still support all event types triggering (the case I described above), via wild card or some sort, or just leave Source.Spec blank.

[loonybear]

@nachocano

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[rhuss]

/remove-lifecycle stale

I think this feature would still make sense ? // @n3wscott

If not, feel free to close the issue.

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[rhuss]

/remove-lifecycle stale