Expected Behavior
Feeds can be materialized when Knative Eventing is installed via ko from sources
Actual Behavior
Feedlet container has Always pull policy so ko.local image cannot be resolved and Job fails
Steps to Reproduce the Problem
- Install Knative Eventing from sources using ko (so not using Knative Eventing release yaml)
- Install using ko github sample (it uses Feed)
- Observe underlying Job status (it fails because Pod startup timeouts)
Additional Info
Probably Always should be changed to IfNotPresent in https://github.com/knative/eventing/blob/master/pkg/controller/feed/resources/job.go#L192
Expected Behavior
Feeds can be materialized when Knative Eventing is installed via ko from sources
Actual Behavior
Feedlet container has Always pull policy so ko.local image cannot be resolved and Job fails
Steps to Reproduce the Problem
Additional Info
Probably
Alwaysshould be changed toIfNotPresentin https://github.com/knative/eventing/blob/master/pkg/controller/feed/resources/job.go#L192