Skip to content

Feedlet doesn't start for ko.local #284

@sslavic

Description

@sslavic

Expected Behavior

Feeds can be materialized when Knative Eventing is installed via ko from sources

Actual Behavior

Feedlet container has Always pull policy so ko.local image cannot be resolved and Job fails

Steps to Reproduce the Problem

  1. Install Knative Eventing from sources using ko (so not using Knative Eventing release yaml)
  2. Install using ko github sample (it uses Feed)
  3. Observe underlying Job status (it fails because Pod startup timeouts)

Additional Info

Probably Always should be changed to IfNotPresent in https://github.com/knative/eventing/blob/master/pkg/controller/feed/resources/job.go#L192

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions