Skip to content

CEAttributes for new types are ignored until the eventing controller gets restarted #2974

@antoineco

Description

@antoineco

Describe the bug

My cluster contains a custom object that exposes the following ceAttributes:

  status:
    ceAttributes:
    - source: eu-central-1:table/sample-table
      type: com.amazon.dynamodb.com.amazon.dynamodb.insert
    - source: eu-central-1:table/sample-table
      type: com.amazon.dynamodb.com.amazon.dynamodb.modify
    - source: eu-central-1:table/sample-table
      type: com.amazon.dynamodb.com.amazon.dynamodb.remove

The custom resource for that object was registered (its CRD was created) while the eventing controller was up.

After registering the custom resource and creating an instance of that resource (the custom object), the eventing controller did not create the corresponding EventTypes:

$ kubectl get eventtypes.eventing.knative.dev
No resources found in default namespace.

But it did after a user-initiated restart:

$ kubectl -n knative-eventing delete pod eventing-controller-64bb96c78d-8lx7x
pod "eventing-controller-64bb96c78d-8lx7x" deleted
$ kubectl get eventtypes.eventing.knative.dev
NAME                               TYPE                         SOURCE                            SCHEMA   BROKER    DESCRIPTION   READY   REASON
1b6034f38200a7c449c2171246b0de21   com.amazon.dynamodb.modify   eu-central-1:table/sample-table            default                 True
9357f37c9cecc7f6440abbbee65ffb64   com.amazon.dynamodb.remove   eu-central-1:table/sample-table            default                 True
e1092d97ce9984b0e13fbce49ab6d132   com.amazon.dynamodb.insert   eu-central-1:table/sample-table            default                 True

Expected behavior

The eventing controller can dynamically handle the addition of new ducks (a Source in this case).

To Reproduce

  1. Deploy eventing core
    1 Deploy a custom source such as GitHubSource
  2. Confirm that the corresponding eventtypes were not created
  3. Restart the eventing controller inside the knative-eventing namespace
  4. Confirm that the corresponding eventtypes were created

Knative release version

master @ 955aa36

Additional context

Related to #2770

Metadata

Metadata

Assignees

Labels

kind/bugCategorizes issue or PR as related to a bug.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions