Skip to content

Meta Channel doesn't conform the spec's status subscribers requirement #3037

@aliok

Description

@aliok

Describe the bug
As noted in #3016 (comment), Channel doesn't have subscribers in the status.

That PR is about adding conformance tests for channels around having subscribers array in the status.

Spec says this:

  • v1alpha1
    Each subscription to a channel is added to the channel
    status.subscribableStatus.subscribers automatically. The ready field of the
    subscriber identified by its uid MUST be set to True when the subscription
    is ready to be processed.
  • v1beta1
    Each subscription to a channel is added to the channel status.subscribers
    automatically. The ready field of the subscriber identified by its uid MUST
    be set to True when the subscription is ready to be processed.

When a channel.messaging.knative.dev is created, by default Knative creates an InMemoryChannel. When we create a subscription against that Channel, InMemoryChannel will have the subscribers in the status, but it is not propagated to channel.messaging.knative.dev. Other fields like status.address are propagated fine.

Expected behavior
channel.messaging.knative.dev should have status.subscribers and #3016 should pass.

To Reproduce

  • Create a channel.messaging.knative.dev
  • Create a subscription
  • No status.subscribers nor status.subscribableStatus.subscribers is there.

See #3016

Knative release version
0.14

Additional context
#3016

Metadata

Metadata

Assignees

Labels

area/channelsarea/test-and-releaseTest infrastructure, tests or releasekind/bugCategorizes issue or PR as related to a bug.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions