-
Notifications
You must be signed in to change notification settings - Fork 630
All the controller container names should be called controller #3048
Copy link
Copy link
Closed
Labels
area/test-and-releaseTest infrastructure, tests or releaseTest infrastructure, tests or releasekind/feature-requestkind/good-first-issueDenotes an issue ready for a new contributor.Denotes an issue ready for a new contributor.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.Denotes an issue or PR has remained open with no activity and has become stale.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
Metadata
Metadata
Assignees
Labels
area/test-and-releaseTest infrastructure, tests or releaseTest infrastructure, tests or releasekind/feature-requestkind/good-first-issueDenotes an issue ready for a new contributor.Denotes an issue ready for a new contributor.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.Denotes an issue or PR has remained open with no activity and has become stale.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Problem
Image override within operator is problematic at the moment.
Some containers have the same names. Some have different name but their pattern is also different.
I proposed making all container names unique at #2794 but that looks like is not the way to go.
However, to be consistent, let's make all controller container names
controller.This is less confusing when we're doing image overrides with the operator.
Persona:
System Integrator
Exit Criteria
All containers have the same name
Time Estimate (optional):
1d
Additional context (optional)
If we agree doing this, we should also do it for serving.
cc @jcrossley3 @houshengbo