Consider renaming controller binaries

[pmorie]

Currently we have a binary called 'controller' (which runs bus-related controllers) and a binary called 'controller-manager' which runs the flow, feed, etc controllers. Perhaps we can call one the 'bus controller' and the other the 'eventing controller', but it should be clearer from their names which controllers they run.

[grantr]

This situation arose because the controller-runtime controller manager (which runs feed and flow controllers) defines its own kubeconfig and master flags which caused a panic when combined with the existing controller command. At the time it was easier to create a separate binary for them, but that was supposed to be temporary.

I have code that combines them at master...grantr:combine-controllers. Tomorrow I'll polish that up and create a PR fixing this.

[evankanderson]

/assign grantr

…

On Wed, Aug 1, 2018 at 4:47 PM Grant Rodgers ***@***.***> wrote: This situation arose because the controller-runtime controller manager (which runs feed and flow controllers) defines its own kubeconfig and master flags which caused a panic when combined with the existing controller command. At the time it was easier to create a separate binary for them, but that was supposed to be temporary. I have code that combines them at master...grantr:combine-controllers <master...grantr:combine-controllers>. Tomorrow I'll polish that up and create a PR fixing this. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#309 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHlyN4T-EQphZba4ORbTJ8zh2vfbkBUQks5uMj4mgaJpZM4VrZ2d> .

-- Evan Anderson <argent@google.com>