Test failed with no address though channel is supposedly ready.

[vaikas]

Describe the bug
While looking for a test failure here:

https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/3599/pull-knative-eventing-integration-tests/1286134876558331904

I noticed this:

    creation.go:77: Creating channel &TypeMeta{Kind:InMemoryChannel,APIVersion:messaging.knative.dev/v1,}-e2e-brokerchannel-channel
    broker_channel_flow_helper.go:158: Failed to get the url for the channel "e2e-brokerchannel-channel": addressable does not have an Address: &{TypeMeta:{Kind:InMemoryChannel APIVersion:messaging.knative.dev/v1} ObjectMeta:{Name:e2e-brokerchannel-channel GenerateName: Namespace:test-broker-channel-flow-v1-beta1-broker-v1-in-memory-chan8bfdm SelfLink:/apis/messaging.knative.dev/v1/namespaces/test-broker-channel-flow-v1-beta1-broker-v1-in-memory-chan8bfdm/inmemorychannels/e2e-brokerchannel-channel UID:060f660a-c198-4ece-8c50-1a54a6dc7f0f ResourceVersion:44245 Generation:1 CreationTimestamp:2020-07-23 03:33:38 +0000 UTC DeletionTimestamp:<nil> DeletionGracePeriodSeconds:<nil> Labels:map[] Annotations:map[messaging.knative.dev/creator:prow-job@knative-tests.iam.gserviceaccount.com messaging.knative.dev/lastModifier:prow-job@knative-tests.iam.gserviceaccount.com messaging.knative.dev/subscribable:v1] OwnerReferences:[] Finalizers:[] ClusterName: ManagedFields:[]} Status:{Address:<nil>}}
        knative.dev/eventing/test/lib.(*Client).GetAddressableURI
        knative.dev/eventing/test/e2e/helpers.BrokerChannelFlowWithTransformation.func1
        knative.dev/eventing/test/lib.(*ComponentsTestRunner).RunTests.func1
        testing.tRunner
        runtime.goexit

Which is quite odd, since right above it will fail if the resource is not ready, yet the object is not ready.
https://github.com/knative/eventing/blob/master/test/e2e/helpers/broker_channel_flow_helper.go#L151

		// create channel for trigger3
		client.CreateChannelOrFail(channelName, &channel)
		client.WaitForResourceReadyOrFail(channelName, &channel)

		// create trigger3 to receive the transformed event, and send it to the channel
		channelURL, err := client.GetAddressableURI(channelName, &channel)
		if err != nil {
			st.Fatalf("Failed to get the url for the channel %q: %+v", channelName, err)
		}

Expected behavior
Channel to work if it's returned as ready.

To Reproduce
Not sure, just saw in the logs

Knative release version
Head

Additional context
I wonder if these are using different listers... Just jotting down since it seems busted.

[vaikas]

Just saw this again and seems to be some cause of flakiness.

https://prow.knative.dev/view/gcs/knative-prow/logs/ci-knative-eventing-continuous/1298121216283906048

   creation.go:330: Creating v1 trigger e2e-brokerchannel-trigger2
    creation.go:77: Creating channel &TypeMeta{Kind:InMemoryChannel,APIVersion:messaging.knative.dev/v1beta1,}-e2e-brokerchannel-channel
    broker_channel_flow_helper.go:157: Failed to get the url for the channel "e2e-brokerchannel-channel": addressable does not have an Address: &{TypeMeta:{Kind:InMemoryChannel APIVersion:messaging.knative.dev/v1beta1} ObjectMeta:{Name:e2e-brokerchannel-channel GenerateName: Namespace:test-broker-channel-flow-trigger-v1-broker-v1-in-memory-chtwstw SelfLink:/apis/messaging.knative.dev/v1beta1/namespaces/test-broker-channel-flow-trigger-v1-broker-v1-in-memory-chtwstw/inmemorychannels/e2e-brokerchannel-channel UID:62956f4c-81c1-42b6-8b2a-eea4d65e771d ResourceVersion:22194 Generation:1 CreationTimestamp:2020-08-25 05:52:22 +0000 UTC DeletionTimestamp:<nil> DeletionGracePeriodSeconds:<nil> Labels:map[] Annotations:map[messaging.knative.dev/creator:prow-job@knative-tests.iam.gserviceaccount.com messaging.knative.dev/lastModifier:prow-job@knative-tests.iam.gserviceaccount.com messaging.knative.dev/subscribable:v1beta1] OwnerReferences:[] Finalizers:[] ClusterName: ManagedFields:[]} Status:{Address:<nil>}}
        knative.dev/eventing/test/lib.(*Client).GetAddressableURI
        	/home/prow/go/src/knative.dev/eventing/test/lib/operation.go:56
        knative.dev/eventing/test/e2e/helpers.BrokerChannelFlowWithTransformation.func1
        	/home/prow/go/src/knative.dev/eventing/test/e2e/helpers/broker_channel_flow_helper.go:155
        knative.dev/eventing/test/lib.(*ComponentsTestRunner).RunTests.func1
        	/home/prow/go/src/knative.dev/eventing/test/lib/test_runner.go:72
        testing.tRunner
        	/root/.gvm/gos/go1.14.6/src/testing/testing.go:1039
        runtime.goexit
N        	/root/.gvm/gos/go1.14.6/src/runtime/asm_amd64.s:1373
 

And yet again the resource is seemingly thought to be Ready, but clearly it is not:

    tracker.go:128: Cleaning resource: "e2e-brokerchannel-channel"
        {
          "apiVersion": "messaging.knative.dev/v1beta1",
          "kind": "InMemoryChannel",
          "metadata": {
            "annotations": {
              "messaging.knative.dev/creator": "prow-job@knative-tests.iam.gserviceaccount.com",
              "messaging.knative.dev/lastModifier": "prow-job@knative-tests.iam.gserviceaccount.com",
              "messaging.knative.dev/subscribable": "v1beta1"
            },
            "creationTimestamp": "2020-08-25T05:52:22Z",
            "generation": 1,
            "name": "e2e-brokerchannel-channel",
            "namespace": "test-broker-channel-flow-trigger-v1-broker-v1-in-memory-chtwstw",
            "resourceVersion": "22194",
            "selfLink": "/apis/messaging.knative.dev/v1beta1/namespaces/test-broker-channel-flow-trigger-v1-broker-v1-in-memory-chtwstw/inmemorychannels/e2e-brokerchannel-channel",
            "uid": "62956f4c-81c1-42b6-8b2a-eea4d65e771d"
          },
          "spec": {},
          "status": {
            "conditions": [
              {
                "lastTransitionTime": "2020-08-25T05:52:22Z",
                "status": "Unknown",
                "type": "Addressable"
              },
              {
                "lastTransitionTime": "2020-08-25T05:52:22Z",
                "status": "Unknown",
                "type": "ChannelServiceReady"
              },
              {
                "lastTransitionTime": "2020-08-25T05:52:22Z",
                "status": "Unknown",
                "type": "DispatcherReady"
              },
              {
                "lastTransitionTime": "2020-08-25T05:52:22Z",
                "status": "Unknown",
                "type": "EndpointsReady"
              },
              {
                "lastTransitionTime": "2020-08-25T05:52:22Z",
                "message": "unsuccessfully observed a new generation",
                "reason": "NewObservedGenFailure",
                "status": "Unknown",
                "type": "Ready"
              },
              {
                "lastTransitionTime": "2020-08-25T05:52:22Z",
                "status": "Unknown",
                "type": "ServiceReady"
              }
            ],
            "observedGeneration": 1
          }
        }

It has not even been reconciled once.