Skip to content

Add retries for webhook failures. #3952

@vaikas

Description

@vaikas

Describe the bug

While looking at this CI failure:
https://prow.knative.dev/view/gcs/knative-prow/logs/ci-knative-eventing-continuous/1299057320398950401

=== CONT  TestBrokerV1Beta1ControlPlane/InMemoryChannel-messaging.knative.dev/v1/Ready_Trigger_V1Beta1_(no_Broker)_set_Broker_and_includes_status.subscriber_Uri
    broker_control_plane_test_helper.go:140: Error: Could not get trigger trigger-no-broker: conversion webhook for eventing.knative.dev/v1, Kind=Trigger failed: Post https://eventing-webhook.knative-eventing-xhyd6284y5.svc:443/resource-conversion?timeout=30s: EOF
=== CONT  TestBrokerV1Beta1DataPlaneConsumer
    creation.go:288: Failed to create v1beta1 trigger "transform-trigger": Internal error occurred: failed calling webhook "webhook.eventing.knative.dev": Post https://eventing-webhook.knative-eventing-xhyd6284y5.svc:443/defaulting?timeout=2s: EOF
=== RUN   TestBrokerV1Beta1ControlPlane/InMemoryChannel-messaging.knative.dev/v1/Ready_Trigger_V1Beta1_includes_status.subscriber_Uri

We should probably add retries here (and other places in these helpers):
https://github.com/knative/eventing/blob/master/test/conformance/helpers/broker_control_plane_test_helper.go#L138

Kind of like this:
https://github.com/knative/eventing/blob/master/test/lib/creation.go#L124

Or use these libraries instead of calling directly to the kubernetes api?

A clear and concise description of what the bug is.

Expected behavior
A clear and concise description of what you expected to happen.

To Reproduce
Steps to reproduce the behavior.

Knative release version

Additional context
Add any other context about the problem here such as proposed priority

Metadata

Metadata

Assignees

Labels

area/test-and-releaseTest infrastructure, tests or releasekind/bugCategorizes issue or PR as related to a bug.kind/good-first-issueDenotes an issue ready for a new contributor.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions