Bus deployments refer to configmaps/secrets from eventing system namespace

[neosab]

Expected Behavior

When you create a Bus with a Spec that has references to config-maps/secrets in that namespace, you end up with a successful provisioner & dispatcher deployments.

Actual Behavior

The config-maps/secrets are expected to be in the eventing system namespace hence the bus deployments (provisioner/dispatcher) fails with CreateContainerConfigError. This is because the bus deployments are now created in the system namespace and not in the bus' namespace (Ref PR #359)

Steps to Reproduce the Problem

Follow the steps in this Kafka Bus README

Step 3 mentions to create a config map in the default namespace and not in the knative-eventing namespace.

Additional Info

Few options:

1. Easy one: Document that the user needs to create the config-maps/secrets in the system namespace
2. Somehow copy the referenced data from the Bus' namespace and use them in the deployment spec.

I would prefer [2] since the user creating the bus needs privileges on the system namespace.

[neosab]

Posted PR #425 with the easy fix

[scothis]

This behavior was caused by an oversight on my part in the development of #359. I didn't test each bus with a clean cluster, so I didn't notice the credentials/config was out of alignment.

Work arounds:

• use a ClusterBus
• create the secret/credentials in native-eventing for the Bus, manage collisions manually

For a permanent fix I think we'll either need to:

• copy referenced secrets and configmaps into the native-eventing namespace via the bus-controller (granting read access to all secrets is 👎)
• wait for Channel Provisioners
• revert Move bus deployments to knative-eventing #359

My gut is to lean on ClusterBus until we have Channel Provisioners. What do you think @neosab ?

[neosab]

My gut is to lean on ClusterBus

That's fine for now. IIUC, even in the Channel Provisioners case, the Provisioner can refer to secrets/config-maps within their namespace. So the provisioner controllers are expected to be available in those namespaces and not in the system namespace?

[vaikas]

obsolete