Round 2: GCP PubSub Source Controller

[evankanderson]

Write a controller for GCP PubSub Event Source and Provisioners. This should:

1. Create the Provisioner/update the Status.
2. Define required fields (if any) in Source arguments.
3. Allocate a Channel to provide fan-out for the Source.
4. Create and manage a GCP Subscription on a specified (already-created) Topic.
5. Copy configuration from Source CR to delivery implementation (Round 2: GCP PubSub Receive Adapter #450).
6. Update Status based on the success of 3, 4, 5.
7. Test coverage > 80%
8. Deployment which runs the Channel controller.
9. Minimal RBAC rules for 1,3,4,5,6.

[n3wscott]

/assign @n3wscott

[adamharwayne]

/assign @adamharwayne

[adamharwayne]

The GcpPubSubSource's controller is in knative/eventing-sources. Specifically here.

1. Create the Provisioner/update the Status.
2. Define required fields (if any) in Source arguments.
3. Allocate a Channel to provide fan-out for the Source.
4. Create and manage a GCP Subscription on a specified (already-created) Topic.
5. Copy configuration from Source CR to delivery implementation (Round 2: GCP PubSub Receive Adapter #450).
6. Update Status based on the success of 3, 4, 5.
7. Test coverage > 80%
8. Deployment which runs the Channel controller.
9. Minimal RBAC rules for 1,3,4,5,6.

1. Out of date, Sources are now CRDs, not ClusterProvisioners. CRD defined here.
2. Done via the CRD's spec.
3. Not done. Currently the Source needs to be provided a Channel in its spec.sink field.
4. Done.
5. The Receive Adapter is done.
6. Done, via the src.Status.Mark*() methods in reconcile.go.
7. Reconciler has 94.6% coverage. The overall package has 83.7% coverage.
8. It is currently deployed in the common eventing-sources controller-manager.
9. It is currently deployed in the common eventing-sources controller-manager, which contains a superset of the required RBAC rules.

[adamharwayne]

/close

[knative-prow-robot]

@adamharwayne: Closing this issue.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.