Problem
When introducing PingSource v1beta2 in 0.20 release, we added PingSource spec annotations to help the conversion as v1beta1 was the storage version and v1beta2 has new features that cannot be persisted in v1beta1.
Given that we flipped storage version to v1beta2 in 0.21, there's no need to keep these 2 annotations. We'll need to remove these annotations by running a post-install job:
const (
V1B1SpecAnnotationKey = "pingsources.sources.knative.dev/v1beta1-spec"
V1B2SpecAnnotationKey = "pingsources.sources.knative.dev/v1beta2-spec"
)
Persona:
Event producer
Exit Criteria
the 2 annotations get removed for all existing PingSource objects.
Time Estimate (optional):
1 day
Additional context (optional)
PR to remove annotation based conversion: #5153, will be released in 0.23 and backported to 0.21 and 0.22. This cleanup should also be released in the same versions
Problem
When introducing PingSource v1beta2 in 0.20 release, we added PingSource spec annotations to help the conversion as v1beta1 was the storage version and v1beta2 has new features that cannot be persisted in v1beta1.
Given that we flipped storage version to v1beta2 in 0.21, there's no need to keep these 2 annotations. We'll need to remove these annotations by running a post-install job:
Persona:
Event producer
Exit Criteria
the 2 annotations get removed for all existing PingSource objects.
Time Estimate (optional):
1 day
Additional context (optional)
PR to remove annotation based conversion: #5153, will be released in 0.23 and backported to 0.21 and 0.22. This cleanup should also be released in the same versions