-
Notifications
You must be signed in to change notification settings - Fork 630
test/lib/creation.go funcs should accept context.Context #5322
Copy link
Copy link
Closed
Labels
area/test-and-releaseTest infrastructure, tests or releaseTest infrastructure, tests or releasekind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.Denotes an issue or PR has remained open with no activity and has become stale.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Metadata
Metadata
Assignees
Labels
area/test-and-releaseTest infrastructure, tests or releaseTest infrastructure, tests or releasekind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.Denotes an issue or PR has remained open with no activity and has become stale.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Describe the bug
Most of the functions in
test/lib/creation.goare creating their own background context within the function. That prevents the operation to be stopped from outside for ex. in case of timeout.Expected behavior
None of the
context.Contextobjects should be created within those create functions.