Rename in-memory-channel ClusterChannelProvisioner

[scothis]

The resource name in-memory-channel is redundant with the resource type ClusterChannelProvisioner. A more streamlined name would be in-memory or perhaps memory. The current name was picked back when sources also used the ClusterProvisioner model.

Additional Info

This is a good candidate for a first time contribution if we agree it's worth doing.

[evankanderson]

I think there was a concern that the rename would cause breakage for existing users. This might be a good chance to look at what a graceful switchover might look like: 1. Create two CCPs: in-memory and in-memory-channel 2. Manage both in-memory and in-memory-channel for the 0.3 release. Publish a release note that users should change the name of their Channels. 3. Remove the in-memory-channel in 0.4. See also the discussion in knative/serving#2639

…

On Wed, Dec 5, 2018 at 4:06 PM Scott Andrews ***@***.***> wrote: The resource name in-memory-channel is redundant with the resource type ClusterChannelProvisioner. A more streamlined name would be in-memory or perhaps memory. The current name was picked back when sources also used the ClusterProvisioner model. Additional Info This is a good candidate for a first time contribution if we agree it's worth doing. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#676>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHlyN1-iNpB4DTX_UurLKNcyaqgPjl6mks5u2F-CgaJpZM4ZFjTx> .

-- Evan Anderson <argent@google.com>

[sbezverk]

@evankanderson @grantr so should it be done? I could probably take care of it if it is still a go.

[grantr]

IMO yes. Would be great to have this in for 0.3.
/milestone v0.3.0

[sbezverk]

@evankanderson @grantr @Harwayne After looking at the code, I think there is no need to have two copies of CCPs. The only thing needed for backward compatibility is to preserve the configmap name in-memory-channel-dispatcher-config-map In this case channels info can be written and read by old and new renamed CCP. Please let me know if my understanding is not correct.

[sbezverk]

/assign @sbezverk

[grantr]

/milestone clear
Removing this from 0.3. See #700 (comment) and followups.

[grantr]

/milestone v0.4.0

[Harwayne]

in-memory was created in #708. in-memory-channel is being kept for backwards compatibility for one release and should be removed in 0.5.0.

/close

[knative-prow-robot]

@Harwayne: Closing this issue.

Details

In response to this:

in-memory was created in #708. in-memory-channel is being kept for backwards compatibility for one release and should be removed in 0.5.0.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.