Skip to content

Triggers working via path, rather than host#1045

Merged
knative-prow-robot merged 9 commits into
knative:masterfrom
Harwayne:trigger-sans-istio
Apr 15, 2019
Merged

Triggers working via path, rather than host#1045
knative-prow-robot merged 9 commits into
knative:masterfrom
Harwayne:trigger-sans-istio

Conversation

@Harwayne
Copy link
Copy Markdown
Contributor

Fixes #918

Proposed Changes

  • Triggers working via path, rather than host.
    • This removes the need to create both K8s Services and Istio VirtualServices.

Release Note

Existing K8s Services and Istio VirtualServices that correspond to Triggers will not be 
deleted proactively. They are cleaned up by K8s Garbage Collection, after their owning 
Trigger has been deleted.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 10, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 10, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2019
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 10, 2019
@Harwayne Harwayne marked this pull request as ready for review April 10, 2019 23:40
@Harwayne
Copy link
Copy Markdown
Contributor Author

/assign @akashrv

Comment thread pkg/reconciler/v1alpha1/trigger/path/path.go Outdated
Comment thread pkg/reconciler/v1alpha1/trigger/path/path.go
Comment thread pkg/reconciler/v1alpha1/trigger/path/path.go
Comment thread pkg/reconciler/v1alpha1/trigger/resources/subscription.go
Comment thread pkg/reconciler/v1alpha1/trigger/trigger.go
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1alpha1/trigger_lifecycle.go Do not exist 71.4%
pkg/broker/receiver.go 82.9% 84.9% 2.0
pkg/reconciler/v1alpha1/subscription/subscription.go 73.1% 73.9% 0.9
pkg/reconciler/v1alpha1/trigger/trigger.go 79.5% 86.7% 7.2

@akashrv
Copy link
Copy Markdown
Contributor

akashrv commented Apr 15, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2019
@knative-prow-robot knative-prow-robot merged commit 0b8927a into knative:master Apr 15, 2019
@Harwayne Harwayne deleted the trigger-sans-istio branch April 15, 2019 20:14
Harwayne added a commit to Harwayne/knative-eventing that referenced this pull request Apr 15, 2019
matzew pushed a commit to matzew/eventing that referenced this pull request Apr 10, 2025
Co-authored-by: serverless-qe <serverless-support@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triggers don't use Istio VirtualServices

5 participants