Remove a few obsolete overrides#1090
Merged
Merged
Conversation
These overrides are very old, and cobra isn't imported anymore. This cleanup has already happened in serving.
Tracking the serving bump in knative#2124.
These were originally added for the PubSub receive adapter in knative#57, but it's been a while and we probably don't need them anymore.
knative-prow-robot
added
size/L
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These overrides are (probably) not necessary anymore.
cobraisn't used anywhere in the projectpflagoverride was removed from serving and build-pipelineprotobufandoauth2overrides were added in Proof of concept GCP Pub Sub using a Receive Adapter #57, almost certainly no longer relevant (but @vaikas-google may remember a good reason to keep them).I updated
pflagto 1.0.3, same as serving./cc @vdemeester
This is not just cleanup: CEL requires protobuf 1.3.0 (for #1047), so we need to remove the 1.1.0 override first.