k8s forces additionalProperties to true, hence no need to set it ourselves

[matzew]

with additionalProperties:true, I am getting the following error:

cannot unmarshal bool into Go struct field JSONSchemaProps.AdditionalProperties of type apiextensions.JSONSchemaPropsOrBool

Since k8s forces it (defaults) to be true, we don't need to explicitly set it to true!

[matzew]

@Harwayne as discussed on slack

[Harwayne]

/approve
/lgtm

/hold

Holding so that you confirm that after this change, you can still send arbitrary data in both locations. Once you test it, remove the hold.

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Harwayne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[matzew]

Holding so that you confirm that after this change, you can still send arbitrary data in both locations. > Once you test it, remove the hold.

@Harwayne

Tested:

• Channel: Source to Channel, subscription for channel, ksvc receives messages
• Broker: Source to Broker, Trigger for event and reference a ksvc and see messages being received

FWIW: all in a non-default namespace ;-)

[n3wscott]

/hold cancel