Skip to content

update test-infra: skip e2e tests for non-code changes#1098

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
chizhg:UpdateTestInfra
Apr 25, 2019
Merged

update test-infra: skip e2e tests for non-code changes#1098
knative-prow-robot merged 1 commit into
knative:masterfrom
chizhg:UpdateTestInfra

Conversation

@chizhg
Copy link
Copy Markdown
Contributor

@chizhg chizhg commented Apr 24, 2019

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 24, 2019
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 24, 2019
Copy link
Copy Markdown
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 24, 2019
Copy link
Copy Markdown
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2019
Comment thread Gopkg.lock Outdated
@adrcunha
Copy link
Copy Markdown
Contributor

24 files updated, broken tests... When the expected is 4 files (and 2 lines in Gopkg). This PR is messed up, probably just needs a rebase.

@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 24, 2019
@chizhg
Copy link
Copy Markdown
Contributor Author

chizhg commented Apr 24, 2019

/hold

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 24, 2019
@chizhg
Copy link
Copy Markdown
Contributor Author

chizhg commented Apr 24, 2019

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2019
@adrcunha
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, Fredy-Z, grantr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit cc11eaa into knative:master Apr 25, 2019
chizhg added a commit to chizhg/eventing that referenced this pull request Apr 25, 2019
@chizhg chizhg deleted the UpdateTestInfra branch April 25, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants