Skip to content

Move Container source to Eventing, migrate to pkg/controller#1099

Merged
knative-prow-robot merged 30 commits into
knative:masterfrom
n3wscott:container_source
Apr 25, 2019
Merged

Move Container source to Eventing, migrate to pkg/controller#1099
knative-prow-robot merged 30 commits into
knative:masterfrom
n3wscott:container_source

Conversation

@n3wscott
Copy link
Copy Markdown
Contributor

@n3wscott n3wscott commented Apr 24, 2019

Related to #734 and knative/eventing-contrib#341
FYI knative/docs#1235

Proposed Changes

  • Move ContainerSource API and Controller to Eventing.

Release Note

ContainerSource CRD will now be installed from knative/eventing.
ContainerSource will be reconciled by eventing.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2019
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 24, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 24, 2019
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2019
@n3wscott n3wscott changed the title [WIP] Move Container source Move Container source to Eventing, migrate to pkg/controller Apr 25, 2019
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2019
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Apr 25, 2019

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/sources/v1alpha1/containersource_lifecycle.go Do not exist 100.0%
pkg/apis/sources/v1alpha1/containersource_types.go Do not exist 0.0%
pkg/apis/sources/v1alpha1/register.go Do not exist 100.0%
pkg/reconciler/containersource/containersource.go Do not exist 80.2%
pkg/reconciler/containersource/resources/deployment.go Do not exist 100.0%
pkg/reconciler/cronjobsource/cronjobsource.go Do not exist 79.8%

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Apr 25, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Apr 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [n3wscott,vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit a5a24f5 into knative:master Apr 25, 2019
This was referenced Apr 25, 2019
Merged
Closed
@n3wscott
Copy link
Copy Markdown
Contributor Author

n3wscott commented Apr 25, 2019

Related to knative/docs#1235

lberk added a commit to lberk/eventing that referenced this pull request Feb 16, 2021
@lberk
Try increasing e2e timeout to 50m, drop brokerManyTestsSkip patch (kn…
e56e3b6 
…ative#1099)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@n3wscott @knative-metrics-robot @vaikas @knative-prow-robot @googlebot