Eventing Webhook Controller#112
Merged
Merged
Conversation
Core structure copied from the webhook in serving. Prevents: - creation of a Channel without a Bus reference - mutation of a Channel's Bus reference - creation of a Subscription without a Channel reference - mutation of a Subscription's Channel reference Fixes #107
google-prow-robot
added
the
size/XXL
vaikas
reviewed
Jun 25, 2018
|
|
||
| const ( | ||
| // TODO(vaikas): Add / change other parts of the cert we might care about | ||
| organization = "kube" |
Contributor
There was a problem hiding this comment.
hehe, perhaps this should be:
knative
Contributor
Author
There was a problem hiding this comment.
Copied from serving, I doubt the cert subject name ends up being impactful, but updating to knative makes sense to me.
| client: client, | ||
| options: options, | ||
| handlers: map[string]GenericCRDHandler{ | ||
| // "Bus": { |
Contributor
Author
There was a problem hiding this comment.
I don't have any extra validation rules for the Bus right now. I'll remove.
Contributor
|
/lgtm |
Contributor
|
/retest |
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: scothis, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
matzew
pushed a commit
to matzew/eventing
that referenced
this pull request
May 20, 2019
Update script to fail fast and use the repo name in the hub command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core structure copied from the webhook in serving, but drops zap since it isn't used in eventing.
Prevents:
Fixes #107