Enable e2e testing for NATSS#1126
Merged
Merged
Conversation
knative-prow-robot
added
the
size/L
Contributor
Author
Contributor
Author
adrcunha
reviewed
Apr 30, 2019
adrcunha
reviewed
Apr 30, 2019
matzew
reviewed
Apr 30, 2019
| } | ||
|
|
||
| # Create resources required for NATSS provisioner setup | ||
| function natss_setup() { |
Member
There was a problem hiding this comment.
should this be in a separate script ? I assume this file can become messy w/ future addons, like for Kafka.
Contributor
There was a problem hiding this comment.
+1 for moving support functions to a separate file. But this can be done in a separate PR IMO.
Member
|
@Fredy-Z should this be instead done on the to be renamed |
Contributor
|
/approve Holding in case you want to address the concern from Matthias. |
knative-prow-robot
added
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, Fredy-Z The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Member
|
agreed!
On Tue 30. Apr 2019 at 22:14, Adriano Cunha ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In test/e2e-tests.sh
<#1126 (comment)>:
> @@ -124,19 +140,33 @@ function gcppubsub_teardown() {
kubectl -n knative-eventing delete secret ${PUBSUB_SECRET_NAME}
}
+# Create resources required for NATSS provisioner setup
+function natss_setup() {
+1 for moving support functions to a separate file. But this can be done
in a separate PR IMO.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1126 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABGPTRDMZ5K6PZ4FKZYLSTPTCSCLANCNFSM4HJO5DEQ>
.
--
Sent from Gmail Mobile
|
Member
|
/cancel hold
On Tue 30. Apr 2019 at 22:16, Matthias Wessendorf ***@***.***> wrote:
agreed!
On Tue 30. Apr 2019 at 22:14, Adriano Cunha ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In test/e2e-tests.sh
> <#1126 (comment)>:
>
> > @@ -124,19 +140,33 @@ function gcppubsub_teardown() {
> kubectl -n knative-eventing delete secret ${PUBSUB_SECRET_NAME}
> }
>
> +# Create resources required for NATSS provisioner setup
> +function natss_setup() {
>
> +1 for moving support functions to a separate file. But this can be done
> in a separate PR IMO.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#1126 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AABGPTRDMZ5K6PZ4FKZYLSTPTCSCLANCNFSM4HJO5DEQ>
> .
>
--
Sent from Gmail Mobile
--
Sent from Gmail Mobile
|
Contributor
Author
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
Member
|
lol
On Tue 30. Apr 2019 at 23:16, Chi Zhang ***@***.***> wrote:
/hold cancel
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1126 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABGPTXHD4YW3RWPNE5WNR3PTCZLFANCNFSM4HJO5DEQ>
.
--
Sent from Gmail Mobile
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
e2e-tests.sha little bit.