Skip to content

Format markdown#1131

Closed
mattmoor-sockpuppet wants to merge 1 commit into
knative:masterfrom
mattmoor-sockpuppet:prettier-knative-eventing2m5rh-pod-3ef168
Closed

Format markdown#1131
mattmoor-sockpuppet wants to merge 1 commit into
knative:masterfrom
mattmoor-sockpuppet:prettier-knative-eventing2m5rh-pod-3ef168

Conversation

@mattmoor-sockpuppet
Copy link
Copy Markdown
Contributor

Produced via: prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github)

Produced via: `prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github)`
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 1, 2019
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 1, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @mattmoor-sockpuppet. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 1, 2019
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test
/approve

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 1, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, mattmoor-sockpuppet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

@mattmoor-sockpuppet: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-eventing-build-tests 1a598fb link /test pull-knative-eventing-build-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Harwayne
Copy link
Copy Markdown
Contributor

Harwayne commented May 1, 2019

#1119 fixes the bad link that is causing the test to fail.

@mattmoor mattmoor closed this May 2, 2019
lberk added a commit to lberk/eventing that referenced this pull request Mar 8, 2021
* Drop 46 ci generation

* Enable promotion for 4.7 images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants