Skip to content

Remove unneeded log keys.#1135

Merged
knative-prow-robot merged 3 commits into
knative:masterfrom
Harwayne:log
May 1, 2019
Merged

Remove unneeded log keys.#1135
knative-prow-robot merged 3 commits into
knative:masterfrom
Harwayne:log

Conversation

@Harwayne
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne commented May 1, 2019

Proposed Changes

  • Remove unneeded log keys.
    • knative.dev/controller is set by pkg/reconciler just before calling our reconciler, so adding a second one in main is redundant and produced entries with:
      {
        "knative.dev/controller": "controller",
        "knative.dev/controller": "trigger-controller",
      }
    • The reconcile key is already saved as 'knative.dev/key' by pkg/reconciler, so we don't need to add 'key' as well.

Release Note

NONE

knative.dev/controller is set by pkg/reconciler just before calling our reconciler, so adding a second one in main is redundant and produced entries with:
{
    "knative.dev/controller": "controller",
    "knative.dev/controller": "trigger-controller",
}

The reconcile key is already saved as 'knative.dev/key' by pkg/reconciler, so we don't need to add 'key' as well.
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 1, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 1, 2019
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2019
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 1, 2019
@Harwayne
Copy link
Copy Markdown
Contributor Author

Harwayne commented May 1, 2019

/test pull-knative-eventing-integration-tests

Copy link
Copy Markdown
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold
Holding for optional suggestions.

Comment thread pkg/reconciler/channel/channel.go Outdated
Comment thread pkg/reconciler/channel/channel.go
@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels May 1, 2019
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label May 1, 2019
Copy link
Copy Markdown
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 1, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/channel/channel.go Do not exist 93.3%
pkg/reconciler/eventtype/eventtype.go Do not exist 77.0%
pkg/reconciler/namespace/namespace.go Do not exist 76.5%
pkg/reconciler/subscription/subscription.go Do not exist 80.3%
pkg/reconciler/trigger/trigger.go Do not exist 83.4%
pkg/reconciler/v1alpha1/broker/broker.go 89.8% 88.0% -1.8

@Harwayne Harwayne marked this pull request as ready for review May 1, 2019 21:22
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2019
@knative-prow-robot knative-prow-robot merged commit 4253a4a into knative:master May 1, 2019
@Harwayne Harwayne deleted the log branch May 9, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants