Skip to content

Upgrade knative/pkg for new stackdriver exporter#1139

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
grantr:upgrade-pkg
May 1, 2019
Merged

Upgrade knative/pkg for new stackdriver exporter#1139
knative-prow-robot merged 1 commit into
knative:masterfrom
grantr:upgrade-pkg

Conversation

@grantr
Copy link
Copy Markdown
Contributor

@grantr grantr commented May 1, 2019

The latest knative/pkg upgrades its dependency on the stackdriver exporter to v0.9.2, which is now compatible with Protobuf 1.3. Upgrading to Protobuf 1.3 allows for the addition of https://github.com/google/cel-go for #1047.

Proposed Changes

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 1, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 1, 2019
@grantr
Copy link
Copy Markdown
Contributor Author

grantr commented May 1, 2019

@shashwathi this PR includes your table testing change from knative/pkg#398.

The latest knative/pkg upgrades its dependency on the stackdriver
exporter to v0.9.2, which is now compatible with protobuf 1.3.
@shashwathi
Copy link
Copy Markdown
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2019
@knative-prow-robot knative-prow-robot merged commit 15bf0ea into knative:master May 1, 2019
@grantr grantr deleted the upgrade-pkg branch May 1, 2019 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants