Skip to content

Remove the deprecated 'in-memory-channel' ClusterChannelProvisioner.#1247

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
Harwayne:remove-in-memory-channel
May 17, 2019
Merged

Remove the deprecated 'in-memory-channel' ClusterChannelProvisioner.#1247
knative-prow-robot merged 1 commit into
knative:masterfrom
Harwayne:remove-in-memory-channel

Conversation

@Harwayne
Copy link
Copy Markdown
Contributor

Fixes #787

Proposed Changes

  • Remove the deprecated 'in-memory-channel' ClusterChannelProvisioner.

Release Note

The `in-memory-channel` ClusterChannelProvisioner has been removed. The recommended replacement is `in-memory`.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 16, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 16, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2019
@Harwayne
Copy link
Copy Markdown
Contributor Author

/assign @akashrv

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/provisioners/inmemory/channel/controller.go 50.0% 64.3% 14.3
pkg/provisioners/inmemory/channel/reconcile.go 94.4% 95.7% 1.4
pkg/provisioners/inmemory/clusterchannelprovisioner/reconcile.go 93.4% 100.0% 6.6
pkg/provisioners/multichannelfanout/config.go Do not exist 100.0%

@Harwayne
Copy link
Copy Markdown
Contributor Author

/test pull-knative-eventing-unit-tests

Unrelated flakiness. Fixed in #1246.

1 similar comment
@Harwayne
Copy link
Copy Markdown
Contributor Author

/test pull-knative-eventing-unit-tests

Unrelated flakiness. Fixed in #1246.

@matzew
Copy link
Copy Markdown
Member

matzew commented May 17, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2019
@knative-prow-robot knative-prow-robot merged commit 175f742 into knative:master May 17, 2019
@Harwayne Harwayne deleted the remove-in-memory-channel branch May 20, 2019 17:00
matzew added a commit to matzew/eventing that referenced this pull request May 7, 2021
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew pushed a commit to matzew/eventing that referenced this pull request Apr 24, 2025
…y-pick-1245-to-release-v1.16

[release-v1.16] Install correct SO version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove in-memory-channel ClusterChannelProvisioner in 0.7

6 participants