Kafka CRD, Controller, and Dispatcher by nachocano · Pull Request #1261 · knative/eventing

nachocano · 2019-05-22T18:07:09Z

Helps with #1216

Proposed Changes

Created a new KafkaChannel CRD. Added types, validation, defaults, etc.
Created a new Kafka channel controller that uses pkg/controller instead of controller runtime. The idea is to deprecate the provisioner based one in 0.7, and then remove it in 0.8. Thus the different names.
Created a new Kafka dispatcher controller that uses pkg/controller instead of controller runtime. This replaces the channelwatcher in the provisioner-based one.

Follow up PRs

Documentation
E2E tests
Controller UTs

Release Note

There is a new KafkaChannel CRD to instantiate Kafka channels. The provisioner based Kafka channel implementation will be deprecated in 0.7.

knative-metrics-robot · 2019-05-28T23:24:15Z

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_defaults.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_lifecycle.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_types.go	Do not exist	0.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_validation.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/register.go	Do not exist	0.0%

knative-metrics-robot · 2019-05-29T01:39:56Z

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_defaults.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_lifecycle.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_types.go	Do not exist	0.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_validation.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/register.go	Do not exist	0.0%

knative-metrics-robot · 2019-05-29T01:43:22Z

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_defaults.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_lifecycle.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_types.go	Do not exist	0.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_validation.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/register.go	Do not exist	0.0%

knative-metrics-robot · 2019-05-29T21:18:46Z

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_defaults.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_lifecycle.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_types.go	Do not exist	0.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_validation.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/register.go	Do not exist	0.0%

nachocano · 2019-05-30T17:34:30Z

ping

knative-metrics-robot · 2019-05-30T17:51:30Z

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_defaults.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_lifecycle.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_types.go	Do not exist	0.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_validation.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/register.go	Do not exist	0.0%

matzew · 2019-05-31T09:50:26Z

/lgtm

matzew · 2019-05-31T10:02:11Z

/test pull-knative-eventing-unit-tests

matzew · 2019-05-31T10:02:26Z

/test pull-knative-eventing-build-tests

nachocano · 2019-05-31T14:22:17Z

It must be due to some changes I need to merge. I guess I'll need an lgtm again :) Will ping you back once I take care of it. Thanks!

nachocano · 2019-05-31T14:59:14Z

@matzew , done the merge. This should make the tests pass. Can you lgtm once more :) Thanks!

knative-metrics-robot · 2019-05-31T15:11:15Z

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_defaults.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_lifecycle.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_types.go	Do not exist	0.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/kafka_channel_validation.go	Do not exist	100.0%
contrib/kafka/pkg/apis/messaging/v1alpha1/register.go	Do not exist	0.0%

nachocano · 2019-05-31T17:04:25Z

/lgtm
myself as @matzew already did, and it was just a merge

knative-prow-robot · 2019-05-31T17:04:26Z

@nachocano: you cannot LGTM your own PR.

Details

In response to this:

/lgtm
myself as @matzew already did, and it was just a merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vaikas · 2019-05-31T19:12:01Z

/lgtm
/approve

knative-prow-robot · 2019-05-31T19:12:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, nachocano, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~contrib/kafka/OWNERS~~ [matzew,vaikas-google]
~~hack/OWNERS~~ [vaikas-google]
~~test/OWNERS~~ [vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Some hacks for the IMC .... Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding the patch to remove unneeded yaml files Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

nachocano added 30 commits May 20, 2019 10:06

messaging

259f727

adding types

5f5fa9d

configs

3d5e3db

more stuff

ecbff88

compiling controller

e843960

updating channel spec

63365eb

moving types down

677f02d

updates to UTs

01e0efc

adding validation that none is empty

c308652

more updates

7023499

Merge remote-tracking branch 'upstream/master' into kafka-crd

bb1c93e

Merge remote-tracking branch 'upstream/master' into kafka-crd

b660845

more updates

9aeaa7f

broken tests...

7ee0863

Merge remote-tracking branch 'upstream/master' into kafka-crd

db55bcd

rollbacking changes

5217601

more rollbacks

881a3fb

rollback controller main

07c383a

moving things down

a7cd931

updating config map

38a9b45

setting defaults

f899572

removing unnecessary file

6577838

removing clientArgs

8088142

removing params

5edb0d9

config-kafka

2556368

patching

affe681

updates

23e8e01

to int

5340871

still errors

aaa21ec

changing dispatcher name

9bf97ab

nachocano added 3 commits May 28, 2019 18:23

removing commented UT to add it in a follow up PR

2876113

Merge remote-tracking branch 'upstream/master' into kafka-crd-1

5fe4f8e

update after merge

f21fc73

adding the subscribable label

8f71f9f

Merge remote-tracking branch 'upstream/master' into kafka-crd-1

28556ab

knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label May 30, 2019

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2019

nachocano added 2 commits May 31, 2019 07:54

Merge remote-tracking branch 'upstream/master' into kafka-crd-1

28b68c3

renaming in trunk

21aa9ac

knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label May 31, 2019

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2019

knative-prow-robot merged commit 60486fe into knative:master May 31, 2019

adrcunha mentioned this pull request Jul 24, 2019

Release notes tooling knative/test-infra#214

Closed

Conversation

nachocano commented May 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Follow up PRs

Uh oh!

knative-metrics-robot commented May 28, 2019

Uh oh!

knative-metrics-robot commented May 29, 2019

Uh oh!

knative-metrics-robot commented May 29, 2019

Uh oh!

knative-metrics-robot commented May 29, 2019

Uh oh!

nachocano commented May 30, 2019

Uh oh!

knative-metrics-robot commented May 30, 2019

Uh oh!

matzew commented May 31, 2019

Uh oh!

matzew commented May 31, 2019

Uh oh!

matzew commented May 31, 2019

Uh oh!

nachocano commented May 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nachocano commented May 31, 2019

Uh oh!

knative-metrics-robot commented May 31, 2019

Uh oh!

nachocano commented May 31, 2019

Uh oh!

knative-prow-robot commented May 31, 2019

Uh oh!

vaikas commented May 31, 2019

Uh oh!

knative-prow-robot commented May 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

nachocano commented May 22, 2019 •

edited

Loading

nachocano commented May 31, 2019 •

edited

Loading