Skip to content

Adding a list of CRDs added by eventing#129

Merged
google-prow-robot merged 5 commits into
knative:masterfrom
n3wscott:document-crds
Jul 2, 2018
Merged

Adding a list of CRDs added by eventing#129
google-prow-robot merged 5 commits into
knative:masterfrom
n3wscott:document-crds

Conversation

@n3wscott
Copy link
Copy Markdown
Contributor

First pass at a list, I intend to document them each or link them to their definition in the codebase in the future.

@google-prow-robot google-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 27, 2018
@n3wscott
Copy link
Copy Markdown
Contributor Author

/assign @vaikas-google

Comment thread README.md Outdated
- EventSource
- EventType

#### Istio
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The istio types are an implementation workaround rather then something eventing is providing.

Comment thread README.md Outdated
# Kubernetes Extensions

Eventing extends Kubernetes with Custom Resource Definitions (CRDs). The
following Custom Resources (CRs) are related in the production and consumption
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "related" the right verb here? I might swap it with "used".

Copy link
Copy Markdown
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2018
@google-prow-robot google-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2018
Copy link
Copy Markdown
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2018
Comment thread README.md

- Bind
- EventSource
- EventType
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These would be infinitely more useful if they linked to more extensive docs about each. I'm guessing those don't exist, but maybe linking to their type definitions would be a reasonable stand-in?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, and will link to this: #147 when I land it.

Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2018
@google-prow-robot google-prow-robot merged commit 2d8507e into knative:master Jul 2, 2018
matzew pushed a commit to matzew/eventing that referenced this pull request May 27, 2019
matzew pushed a commit to matzew/eventing that referenced this pull request Feb 23, 2023
* CASC changes

* CASC changes

---------

Co-authored-by: Alston Dias <Alston.Dias@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants