Add E2E test case for cron job source#1303
Merged
knative-prow-robot merged 2 commits intoJun 5, 2019
Merged
Conversation
knative-prow-robot
added
do-not-merge/hold
knative-prow-robot
added
the
area/test-and-release
Contributor
Author
|
/retest |
chizhg
changed the title
knative-prow-robot
added
size/L
serviceaccount is not required for cronjobsource fix minor commment error make the comment clearer
chizhg
force-pushed
the
AddTestForCronJobSource
branch
from
2f40357 to
43f4be1
Compare
Contributor
Author
|
/cc @Harwayne |
Contributor
Author
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
Contributor
Author
|
Ping. |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fredy-Z, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
skonto
pushed a commit
to skonto/eventing
that referenced
this pull request
Jun 16, 2021
knative#1303) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I revisited the samples of eventing sources, and I think there is no need to have a separate testing framework for eventing sources now. We can just create the EventSource resource, add a Kubernetes Service sink for it (we can just use the existed logger pod), and check if the Service can receive the events.
Probably in the future when we have an eventing sources framework, we can design a corresponding testing framework. But for now since we have decided to put
CronJobSourceunder eventing repo, I think it would be good to have E2E test coverage for it.Release Note
/cc @adrcunha