Kafka Webhook and Documentation#1316
Conversation
knative-prow-robot
added
the
size/L
|
/assign @vaikas-google |
| numPartitions: 1 | ||
| replicationFactor: 3 | ||
| ``` | ||
| You can configure the number of partitions with `numPartitions`, as well as the replication factor with `replicationFactor`. If not set, both will default to `1`. |
There was a problem hiding this comment.
should this doc say, how to connect to the broker ? or use as default channel ?
There was a problem hiding this comment.
I think we need better documentation for all channels. And we should put that in knative/docs.
This is a copy/paster from the current provisioner-based README, plus some minor changes.
IMO we can add that in a follow up in knative/docs. What do you think?
|
@matzew done with changes. If you can take another look, so that we can merge this in, and then focus on the follow ups, it'd be great. |
|
/lgtm
On Mon 3. Jun 2019 at 18:34, Ignacio Cano ***@***.***> wrote:
@matzew <https://github.com/matzew> done with changes. If you can take
another look, so that we can merge this in, and then focus on the follow
ups, it'd be great.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1316?email_source=notifications&email_token=AABGPTWAUWZ7SRE4T7LSOI3PYVBX7A5CNFSM4HR5XWBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWZ665Y#issuecomment-498331511>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABGPTS6S3QJA37OXCQXKVTPYVBX7ANCNFSM4HR5XWBA>
.
--
Sent from Gmail Mobile
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nachocano, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
6 participants
Fixes #1216
Proposed Changes
Release Note