[WIP]Cleanup before adding E2E test for KafkaChannel#1319
Conversation
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
…y-Z/eventing into AddTestForContainerSource
knative-prow-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Fredy-Z If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow-robot
added
the
area/test-and-release
|
/uncc @n3wscott |
| // InMemoryChannelKind is the kind for InMemoryChannel. | ||
| InMemoryChannelKind string = "InMemoryChannel" | ||
| // KafkaChannelKind is the kind for KafkaChannel. | ||
| KafkaChannelKind string = "KafkaChannel" |
There was a problem hiding this comment.
I can still select that the e2e tests run on a set of given channels ? E.g. just kafka and in-mem >?
There was a problem hiding this comment.
Yes. The flag will still be named as clusterChannelProvisioners until provisioner implementation is removed.
chizhg
changed the title
chizhg
changed the title
|
Close this PR as we will have it all the change in the following PRs. |
4 participants
Proposed Changes
Some cleanup and refactor for the current code before adding E2E test to Kafka Channel CRD.
This PR contains change in #1309, please hold until it is merged.
/hold
Release Note