Skip to content

Data plane updates for InMemory Channel CRD#1339

Merged
knative-prow-robot merged 11 commits into
knative:masterfrom
nachocano:inmemory-crd
Jun 5, 2019
Merged

Data plane updates for InMemory Channel CRD#1339
knative-prow-robot merged 11 commits into
knative:masterfrom
nachocano:inmemory-crd

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

@nachocano nachocano commented Jun 4, 2019

Helps with #1215

Proposed Changes

  • Updating dispatcher part of the InMemoryChannel CRD.
  • Small refactor, moving away from the channelWatcher and creating a new reconciler. Also moved out of main some of the "dispatcher" code.
  • Adding read/write permissions of inmemorychannels to the eventing-controller (needed by the subscription controller)

Follow up PRs

  • E2E test, which @Fredy-Z is already working on

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 4, 2019
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 4, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Jun 4, 2019

working e2e on my cluster. It'd be nice to have this in asap, so that we can have the e2e tests for this.

/assign @vaikas-google

@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Jun 4, 2019

/assign @akashrv

@nachocano nachocano mentioned this pull request Jun 4, 2019
Closed
@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Jun 4, 2019

removed the verbs for inmemorychannels from eventing-controller, as we will properly add them in #1341. Once that one is in, this should work e2e.

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jun 5, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2019
nachocano added 3 commits June 4, 2019 20:54
@nachocano
Merge branch 'inmemory-crd' of github.com:nachocano/eventing into inm…
77a10a2 
…emory-crd

# Conflicts:
#	cmd/in_memory/channel_dispatcher/main.go
#	config/channels/in-memory-channel/200-dispatcher-clusterrole.yaml
#	config/channels/in-memory-channel/500-dispatcher.yaml
#	pkg/inmemorychannel/dispatcher.go
#	pkg/reconciler/inmemorychannel/dispatcher/inmemorychannel.go
@nachocano
Merge remote-tracking branch 'upstream/master' into inmemory-crd
b3d304e
@nachocano
moved
0c81145
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2019
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jun 5, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2019
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Jun 5, 2019

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/inmemorychannel/dispatcher.go Do not exist 30.0%
pkg/reconciler/inmemorychannel/controller/controller.go Do not exist 100.0%
pkg/reconciler/inmemorychannel/controller/inmemorychannel.go Do not exist 80.6%
pkg/reconciler/inmemorychannel/controller/resources/service.go Do not exist 100.0%
pkg/reconciler/inmemorychannel/dispatcher/inmemorychannel.go Do not exist 83.3%

@knative-prow-robot knative-prow-robot merged commit 2985b9d into knative:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@Harwayne Harwayne Awaiting requested review from Harwayne

1 more reviewer

@mattmoor-sockpuppet mattmoor-sockpuppet mattmoor-sockpuppet left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vaikas vaikas

@akashrv akashrv

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nachocano @vaikas @knative-prow-robot @knative-metrics-robot @mattmoor-sockpuppet @googlebot @akashrv