Skip to content

In memory subscribable status (fix fallout from #1330)#1359

Merged
knative-prow-robot merged 3 commits into
knative:masterfrom
vaikas:in-memory-subscribable
Jun 6, 2019
Merged

In memory subscribable status (fix fallout from #1330)#1359
knative-prow-robot merged 3 commits into
knative:masterfrom
vaikas:in-memory-subscribable

Conversation

@vaikas
Copy link
Copy Markdown
Contributor

@vaikas vaikas commented Jun 6, 2019

References #1189

Proposed Changes

  • Change InMemoryChannel to conform to the new subscribable status.
  • Namely now have these fields:
    duckv1alpha1.AddressStatus json:",inline"
    eventingduck.SubscribableTypeStatus json:",inline"
  • Modeled after Channel and Subscription Readiness #1330

Release Note

Change the Status.Addressable to inlined: duckv1alpha1.AddressStatus
Add inlined: eventingduck.SubscribableTypeStatus

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 6, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 6, 2019
- get
- list
- watch
# Updates the status to reflect subscribable status.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need something for finalizers, like:

- apiGroups:
- eventing.knative.dev
resources:
- channels/finalizers
- clusterchannelprovisioners/finalizers
verbs:
- update

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My changes should not require anything about that, just that the dispatcher needs to update /status. Or mayhaps I misunderstand what you meant.

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/inmemorychannel/dispatcher/inmemorychannel.go 83.3% 84.1% 0.8

@matzew
Copy link
Copy Markdown
Member

matzew commented Jun 6, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit a57f6a2 into knative:master Jun 6, 2019
@vaikas vaikas deleted the in-memory-subscribable branch June 6, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants