In memory subscribable status (fix fallout from #1330)#1359
Conversation
| - get | ||
| - list | ||
| - watch | ||
| # Updates the status to reflect subscribable status. |
There was a problem hiding this comment.
do we need something for finalizers, like:
eventing/config/provisioners/in-memory-channel/in-memory-channel.yaml
Lines 48 to 54 in 01fcacd
There was a problem hiding this comment.
My changes should not require anything about that, just that the dispatcher needs to update /status. Or mayhaps I misunderstand what you meant.
|
The following is the coverage report on pkg/.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
References #1189
Proposed Changes
duckv1alpha1.AddressStatus
json:",inline"eventingduck.SubscribableTypeStatus
json:",inline"Release Note