Add e2e test for api server source#1362
Merged
knative-prow-robot merged 2 commits intoJun 15, 2019
Merged
Conversation
knative-prow-robot
added
do-not-merge/hold
knative-prow-robot
added
the
area/test-and-release
chizhg
force-pushed
the
AddTestForApiServerSource
branch
from
becc37f to
c0c00b6
Compare
knative-prow-robot
added
size/L
chizhg
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
Contributor
Author
|
/uncc @ericKlawitter |
knative-prow-robot
requested review from
vaikas
and removed request for
dushyanthsc and
ericKlawitter
chizhg
force-pushed
the
AddTestForApiServerSource
branch
from
f4fe649 to
315b622
Compare
Member
|
/lgtm |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fredy-Z, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1356
Proposed Changes
ApiServerSourceRelease Note