Add a ServiceAccount for Eventing Source Controller#1490
Merged
Conversation
knative-prow-robot
added
the
size/M
daisy-ycguo
force-pushed
the
serviceaccount
branch
from
dcb69f9 to
6db27ef
Compare
knative-prow-robot
added
size/L
Contributor
Author
|
/retest |
n3wscott
reviewed
Jul 2, 2019
|
|
||
| --- | ||
|
|
||
| apiVersion: rbac.authorization.k8s.io/v1 |
Contributor
There was a problem hiding this comment.
This also needs a role for addressable-resolver
matzew
reviewed
Jul 2, 2019
| eventing.knative.dev/release: devel | ||
| spec: | ||
| serviceAccountName: eventing-controller | ||
| serviceAccountName: eventing-source-controller |
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
daisy-ycguo
force-pushed
the
serviceaccount
branch
from
b62cbc5 to
be47bc5
Compare
Member
|
/lgtm
On Tue 2. Jul 2019 at 20:16, Ying Chun Guo ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In config/500-sources-controller.yaml
<#1490 (comment)>:
> @@ -32,7 +32,7 @@ spec:
app: sources-controller
eventing.knative.dev/release: devel
spec:
- serviceAccountName: eventing-controller
+ serviceAccountName: eventing-source-controller
thanks.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1490?email_source=notifications&email_token=AABGPTVQHUWIZWNNRCUZWQLP5OLQDA5CNFSM4H4P2KLKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5JILVA#discussion_r299619151>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABGPTSZJCD3CRNTI7TTYDLP5OLQDANCNFSM4H4P2KLA>
.
--
Sent from Gmail Mobile
|
Contributor
|
/lgtm Thanks! |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: daisy-ycguo, Harwayne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
lberk
pushed a commit
to lberk/eventing
that referenced
this pull request
Jul 15, 2019
* add Kubernetes ServiceAccount for Eventing Source Controller * Update config/200-sourcecontroller-clusterrole.yaml Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com> * update sourcecontroller clusterrole * remove sources resources from controller clusterrole * Update config/200-sourcecontroller-clusterrole.yaml Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com> * add addressable-resolver to eventing-source-controller
devguyio
pushed a commit
to devguyio/eventing
that referenced
this pull request
Nov 22, 2021
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1326
Proposed Changes
Release Note