Skip to content

Disable logging headers in nats dispatcher#1552

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
sayanh:disable-logging-headers-in-nats-dispatcher
Jul 25, 2019
Merged

Disable logging headers in nats dispatcher#1552
knative-prow-robot merged 2 commits into
knative:masterfrom
sayanh:disable-logging-headers-in-nats-dispatcher

Conversation

@sayanh
Copy link
Copy Markdown
Contributor

@sayanh sayanh commented Jul 23, 2019

Fixes #1551

Proposed Changes

  • Changing log level for headers in natss dispatcher to debug

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 23, 2019
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @sayanh. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lionelvillard
Copy link
Copy Markdown
Contributor

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2019
@devguyio
Copy link
Copy Markdown
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2019
@Harwayne
Copy link
Copy Markdown
Contributor

Does this solve #1551? Wouldn't the same information be present in the logs if the log level is changed? I believe the log level can be changed dynamically at runtime.

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jul 25, 2019

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sayanh, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2019
@knative-prow-robot knative-prow-robot merged commit 2d3cd21 into knative:master Jul 25, 2019
maschmid pushed a commit to maschmid/eventing that referenced this pull request Sep 8, 2025
Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
Co-authored-by: red-hat-konflux-kflux-prd-rh02[bot] <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change log level for natss dispatcher to debug for message headers

7 participants